[build] Bug Fix: ensure unique artifact name for e2e tests #6035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I misinterpreted the scope of the breaking change in actions/upload-artifact@v4 in #6029 - looks like we do need to change the name to include the matrix.
Test plan
Before
If a build has more than one e2e test job that fails, uploading the artifacts for that job will fail
After
All e2e failure artifacts should be uploaded