-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Percentage support for gap styles #980
Conversation
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Differential Revision: D56002340
Summary: X-link: facebook/litho#980 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Differential Revision: D56002340
9559991
to
57e9865
Compare
Summary: X-link: facebook/litho#980 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Differential Revision: D56002340
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/litho#980 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
Summary: X-link: facebook/react-native#44067 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
57e9865
to
deb3eea
Compare
Summary: X-link: facebook/react-native#44067 X-link: facebook/litho#980 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/litho#980 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
Summary: X-link: facebook/react-native#44067 X-link: facebook/litho#980 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
deb3eea
to
66fa66b
Compare
Summary: X-link: facebook/react-native#44067 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/litho#980 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
Summary: X-link: facebook/react-native#44067 X-link: facebook/litho#980 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
Summary: X-link: facebook/react-native#44067 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
66fa66b
to
095dcf4
Compare
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/litho#980 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
Summary: X-link: facebook/react-native#44067 X-link: facebook/litho#980 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
Summary: X-link: facebook/react-native#44067 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
095dcf4
to
6df2323
Compare
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/react-native#44067 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340
6df2323
to
c9b58e1
Compare
This pull request was exported from Phabricator. Differential Revision: D56002340 |
Summary: X-link: facebook/react-native#44067 X-link: facebook/litho#980 Pull Request resolved: #1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340 fbshipit-source-id: c0bc86ac70a1391f115c87da99c2ef411535f68b
This pull request has been merged in 722b854. |
Summary: Pull Request resolved: #44067 X-link: facebook/litho#980 X-link: facebook/yoga#1643 Changelog [Internal]: - Added percentage value for flex layout gap - Wired up to pass proper available width and height to implement this feature Reviewed By: NickGerleman Differential Revision: D56002340 fbshipit-source-id: c0bc86ac70a1391f115c87da99c2ef411535f68b
Summary:
Changelog [Internal]:
Differential Revision: D56002340