Skip to content

Commit

Permalink
Revert D40407451: stricter noexcept enforcement in Function
Browse files Browse the repository at this point in the history
Differential Revision:
D40407451 (ae7ecc8)

Original commit changeset: c5c9aba214b7

Original Phabricator Diff: D40407451 (ae7ecc8)

fbshipit-source-id: c68674a48b7d46c7c9b0d699a4b10eed54f880e9
  • Loading branch information
Subash Luitel authored and facebook-github-bot committed Dec 20, 2022
1 parent ae7ecc8 commit 7f9e6f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion mcrouter/lib/network/test/AsyncMcClientTestSync.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ class AsyncMcClientSSLOffloadTest : public TestWithParam<bool> {
TEST_P(AsyncMcClientSSLOffloadTest, connectErrors) {
bool verifyCalled = false;
McSSLUtil::setApplicationSSLVerifier(
[&](folly::AsyncSSLSocket*, bool, X509_STORE_CTX*) noexcept {
[&](folly::AsyncSSLSocket*, bool, X509_STORE_CTX*) {
verifyCalled = true;
return false;
});
Expand Down
8 changes: 2 additions & 6 deletions mcrouter/lib/network/test/AsyncMcServerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ TEST(AsyncMcServer, sslCertCommonName) {

TEST(AsyncMcServer, sslVerify) {
McSSLUtil::setApplicationSSLVerifier(
[](folly::AsyncSSLSocket*, bool, X509_STORE_CTX*) noexcept {
return false;
});
[](folly::AsyncSSLSocket*, bool, X509_STORE_CTX*) { return false; });
TestServer::Config config;
config.outOfOrder = false;
auto server = TestServer::create(std::move(config));
Expand Down Expand Up @@ -240,9 +238,7 @@ TEST(AsyncMcServer, tcpZeroCopyEnabled) {

TEST(AsyncMcServer, tcpZeroCopySSLEnabled) {
McSSLUtil::setApplicationSSLVerifier(
[](folly::AsyncSSLSocket*, bool, X509_STORE_CTX*) noexcept {
return false;
});
[](folly::AsyncSSLSocket*, bool, X509_STORE_CTX*) { return false; });
TestServer::Config config;
config.tcpZeroCopyThresholdBytes = 12000;
config.outOfOrder = false;
Expand Down

0 comments on commit 7f9e6f0

Please sign in to comment.