Introducing HostWithShard-fwd.h (#9336) #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D43301867 |
Summary: Small build speed observation, which combined with more changes will cut some headers from FciClientFactory.cpp. Context: Overall goal is to improve build time of cacheclient/fci/impl/FciClientFactory.cpp which is top 17 in fbcode by EYS opportunity: https://docs.google.com/spreadsheets/d/1k_bDFyLX8ZRRz-B_hy2WvmDKsi8oujEWpqYQsZLJj2o/edit#gid=779559517&range=B19 https://fb.workplace.com/notes/870863330752281 Based on preliminary results, the stack improves many files: https://fburl.com/scuba/clang_perf_stat/a4fkwn82 Differential Revision: D43330734 fbshipit-source-id: 5e512b1e5c0637ee480b6a53f8412fe1d5856b03
Summary: This should improve compilation time for cpp files that include ProxyDestination.h The idea is to extract namespace level functions that do not depend on any template parameters and move its implementation to cpp file. Differential Revision: D43330735 fbshipit-source-id: 775a16ffdfd809fbf39c556c5b70fc6159878312
Summary: Pull Request resolved: facebook#403 X-link: facebook/hhvm#9336 This will help to avoid full mcrouter_sr_deps.h include in some headers. Differential Revision: D43301867 fbshipit-source-id: d809fb4255f35222a9523b7a097b2ae8bb558c51
|
This pull request was exported from Phabricator. Differential Revision: D43301867 |
antonl2
force-pushed
the
export-D43301867
branch
from
e0a947c
to
39f8e4c
Compare
antonl2
added a commit
to antonl2/hhvm
that referenced
this pull request
Feb 16, 2023
Summary: X-link: facebook/mcrouter#403 Pull Request resolved: facebook#9336 This will help to avoid full mcrouter_sr_deps.h include in some headers. Differential Revision: D43301867 fbshipit-source-id: 6f271b92d5c6759385bc7c8f68fdb2ca3367991e
|
This pull request has been merged in b167f4e. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 17, 2023
Summary: X-link: facebook/mcrouter#403 Pull Request resolved: #9336 This will help to avoid full mcrouter_sr_deps.h include in some headers. Differential Revision: D43301867 fbshipit-source-id: a734f1e2c280ba74186e3ceb61cfcc7dd838e052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/hhvm#9336
This will help to avoid full mcrouter_sr_deps.h include in some headers.
Differential Revision: D43301867