Skip to content

Commit

Permalink
feat!: use Terser's default for comments (#972)
Browse files Browse the repository at this point in the history
Summary:
By default, Terser keeps JSDoc-style comments that contain `license` or `preserve`: https://terser.org/docs/api-reference#format-options

Note that this is potentially a breaking change as it may change the output bundle (increase in size).

Pull Request resolved: #972

Test Plan: All current tests should pass.

Reviewed By: motiz88

Differential Revision: D46591290

Pulled By: jacdebug

fbshipit-source-id: a94fcd635a9ac2d0d87ddd0bf3fe82f0c6436c82
  • Loading branch information
tido64 authored and facebook-github-bot committed Jun 26, 2023
1 parent 166477e commit 260125e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ Object {
},
"output": Object {
"ascii_only": true,
"comments": false,
"quote_style": 3,
"wrap_iife": true,
},
Expand Down Expand Up @@ -311,7 +310,6 @@ Object {
},
"output": Object {
"ascii_only": true,
"comments": false,
"quote_style": 3,
"wrap_iife": true,
},
Expand Down Expand Up @@ -490,7 +488,6 @@ Object {
},
"output": Object {
"ascii_only": true,
"comments": false,
"quote_style": 3,
"wrap_iife": true,
},
Expand Down Expand Up @@ -669,7 +666,6 @@ Object {
},
"output": Object {
"ascii_only": true,
"comments": false,
"quote_style": 3,
"wrap_iife": true,
},
Expand Down
1 change: 0 additions & 1 deletion packages/metro-config/src/defaults/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ const getDefaultValues = (projectRoot: ?string): ConfigT => ({
},
output: {
ascii_only: true,
comments: false,
quote_style: 3,
wrap_iife: true,
},
Expand Down

0 comments on commit 260125e

Please sign in to comment.