let the minifier handle comments

facebook · Apr 19, 2023 · bd567e5 · bd567e5
1 parent 227989b
commit bd567e5
Show file tree

Hide file tree

Showing 5 changed files with 200 additions and 173 deletions.
diff --git a/packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap b/packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap
@@ -132,6 +132,7 @@ Object {
       },
       "output": Object {
         "ascii_only": true,
+        "comments": false,
         "quote_style": 3,
         "wrap_iife": true,
       },
@@ -151,7 +152,6 @@ Object {
     "unstable_dependencyMapReservedName": null,
     "unstable_disableModuleWrapping": false,
     "unstable_disableNormalizePseudoGlobals": false,
-    "unstable_preserveComments": false,
     "workerPath": "metro/src/DeltaBundler/Worker",
   },
   "transformerPath": "",
@@ -311,6 +311,7 @@ Object {
       },
       "output": Object {
         "ascii_only": true,
+        "comments": false,
         "quote_style": 3,
         "wrap_iife": true,
       },
@@ -330,7 +331,6 @@ Object {
     "unstable_dependencyMapReservedName": null,
     "unstable_disableModuleWrapping": false,
     "unstable_disableNormalizePseudoGlobals": false,
-    "unstable_preserveComments": false,
     "workerPath": "metro/src/DeltaBundler/Worker",
   },
   "transformerPath": "",
@@ -490,6 +490,7 @@ Object {
       },
       "output": Object {
         "ascii_only": true,
+        "comments": false,
         "quote_style": 3,
         "wrap_iife": true,
       },
@@ -509,7 +510,6 @@ Object {
     "unstable_dependencyMapReservedName": null,
     "unstable_disableModuleWrapping": false,
     "unstable_disableNormalizePseudoGlobals": false,
-    "unstable_preserveComments": false,
     "workerPath": "metro/src/DeltaBundler/Worker",
   },
   "transformerPath": "",
@@ -669,6 +669,7 @@ Object {
       },
       "output": Object {
         "ascii_only": true,
+        "comments": false,
         "quote_style": 3,
         "wrap_iife": true,
       },
@@ -688,7 +689,6 @@ Object {
     "unstable_dependencyMapReservedName": null,
     "unstable_disableModuleWrapping": false,
     "unstable_disableNormalizePseudoGlobals": false,
-    "unstable_preserveComments": false,
     "workerPath": "metro/src/DeltaBundler/Worker",
   },
   "transformerPath": "",

diff --git a/packages/metro-config/src/defaults/index.js b/packages/metro-config/src/defaults/index.js
@@ -111,6 +111,7 @@ const getDefaultValues = (projectRoot: ?string): ConfigT => ({
       },
       output: {
         ascii_only: true,
+        comments: false,
         quote_style: 3,
         wrap_iife: true,
       },
@@ -134,7 +135,6 @@ const getDefaultValues = (projectRoot: ?string): ConfigT => ({
     unstable_disableModuleWrapping: false,
     unstable_disableNormalizePseudoGlobals: false,
     unstable_compactOutput: false,
-    unstable_preserveComments: false,
   },
   watcher: {
     additionalExts,