-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract node-haste
to new metro-dependency-graph
module
#340
Conversation
node-haste
to new 'metro-dependency-graph' modulenode-haste
to new metro-dependency-graph
module
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
- Coverage 85.06% 84.76% -0.31%
==========================================
Files 172 175 +3
Lines 5223 5296 +73
Branches 797 800 +3
==========================================
+ Hits 4443 4489 +46
- Misses 693 715 +22
- Partials 87 92 +5
Continue to review full report at Codecov.
|
@mjesun I know you had some plans around this code, could you comment here and then make a decision on this PR? |
I'm happy to finally get rid of the "node-haste" folder. If you rebase, I can land it. |
987f8a3
to
82f7d77
Compare
Dang, sorry @skevy I didn't get a notification when you pushed. Do you mind doing one more rebase and then commenting here so I can actually merge it? |
@skevy are you still interested in landing this? |
I guess not :( |
@cpojer ha sorry I missed your messages. I am actually interested in finishing this, just not sure when I’ll have time to do it. Closing for now is totally fine — I’ll get it done one of these days! Thanks for keeping me honest. |
Summary
I've been meaning to do this for a while, and finally got around to finishing this PR.
I'd like to use the Metro dependency graph as a separate package for some work at Airbnb. This PR extracts all the existing dependency graph code (previously in
node-haste
directory) to a newmetro-dependency-graph
package.No functionality should have changed, and besides changing imports, most of this diff should just be shifting files around.
It's worth noting that there may be follow ups needed to make this module truly useful outside of Metro, but this is step 1.
Test plan
Run tests.
cc @mjesun @rafeca