metro-react-native-babel-preset support TypeScript namespace #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 175 175
Lines 5864 5864
Branches 973 973
=======================================
Hits 4930 4930
Misses 822 822
Partials 112 112
Continue to review full report at Codecov.
|
bolasblack
force-pushed
the
feat/babel-preset-support-ts-namespace
branch
from
4b38c61
to
f7d48ed
Compare
bolasblack
force-pushed
the
feat/babel-preset-support-ts-namespace
branch
from
f7d48ed
to
4082024
Compare
cpojer
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because the
namespaceis really useful in many case, so I try to makemetro-react-native-babel-presetto support thenamespacekeyword.I added the
allowNamespacesoption to@babel/plugin-transform-typescript.https://babeljs.io/docs/en/babel-plugin-transform-typescript#impartial-namespace-support
Test plan
I linked
metro-react-native-babel-presetto a TypeScript react-native project, and written a namespace, then checked the code metro outputed, it is ok.