Allow for async minifiers #754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terser v5 is async, so if we want to upgrade to support the latest syntax we need this.
facebook-github-bot
added
CLA Signed
|
#606 is related - but this doesn't change the terser package - I'll send another PR for that. That PR was never merged because of a need for using the transform worker sync, but I believe that is obsolete as there is already a bunch of await clauses in that file |
|
@sota000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@sota000 is there any hope of merging this? |
|
@rockwotj this requires a few modifications to the way we use metro internally, but it’s in the pipeline |
|
Thanks so much! |
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Mar 14, 2022
Summary: **Summary** Terser v5 is async, so if we want to upgrade to support the latest syntax we need this. **Test plan** Existing unit tests - this only adds an await clause, which is safe to do to non-promises, so it shouldn't break anything. Pull Request resolved: facebook#754 Reviewed By: motiz88 Differential Revision: D33486073 Pulled By: rh389 fbshipit-source-id: 1f6be79741144960803d018d48a51a367665708f
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 21, 2022
Summary: **Summary** Terser v5 is async, so if we want to upgrade to support the latest syntax we need this. **Test plan** Existing unit tests - this only adds an await clause, which is safe to do to non-promises, so it shouldn't break anything. Pull Request resolved: facebook#754 Reviewed By: motiz88 Differential Revision: D33486073 Pulled By: rh389 fbshipit-source-id: 1f6be79741144960803d018d48a51a367665708f
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 22, 2022
Summary: **Summary** Terser v5 is async, so if we want to upgrade to support the latest syntax we need this. **Test plan** Existing unit tests - this only adds an await clause, which is safe to do to non-promises, so it shouldn't break anything. Pull Request resolved: facebook#754 Reviewed By: motiz88 Differential Revision: D33486073 Pulled By: rh389 fbshipit-source-id: 1f6be79741144960803d018d48a51a367665708f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Terser v5 is async, so if we want to upgrade to support the latest syntax we need this.
Test plan
Existing unit tests - this only adds an await clause, which is safe to do to non-promises, so it shouldn't break anything.