Skip to content

Commit

Permalink
Fixing slave_check_before_image_consistency in MTS mode
Browse files Browse the repository at this point in the history
Summary:
In MTS mode we were not carrying over the cached variable used to
enable the consistency check from rli to workers causing the workers to always
skip the check.

Squash with D15298652

Reviewed By: anirbanr-fb

Differential Revision: D16505567

fbshipit-source-id: 1207a00
  • Loading branch information
abhinav04sharma authored and facebook-github-bot committed Jul 26, 2019
1 parent 7e67c47 commit 64b9e89
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
Expand Up @@ -5,6 +5,7 @@ Note #### Storing MySQL user name or password information in the master info rep
[connection master]
include/rpl_set_gtid_mode.inc
call mtr.add_suppression("Error_code: 1032");
call mtr.add_suppression("Error_code: 1756");
create table t1 (a int primary key, b int, c int) engine = innodb;
create table t2 (a int unique, b int, c int) engine = innodb;
create table t3 (a int, b int, c int, key(a)) engine = innodb;
Expand Down
@@ -1 +1 @@
--slave_check_before_image_consistency=ON
--slave_check_before_image_consistency=ON --slave_parallel_workers=8
Expand Up @@ -3,6 +3,7 @@ source include/have_binlog_format_row.inc;
source include/rpl_set_gtid_mode.inc;

call mtr.add_suppression("Error_code: 1032");
call mtr.add_suppression("Error_code: 1756");

let $engine= innodb;

Expand Down
1 change: 1 addition & 0 deletions sql/rpl_rli_pdb.cc
Expand Up @@ -318,6 +318,7 @@ int Slave_worker::init_worker(Relay_log_info * rli, ulong i)
mts_dependency_refill_threshold= c_rli->mts_dependency_refill_threshold;
mts_dependency_max_keys= c_rli->mts_dependency_max_keys;
mts_dependency_order_commits= c_rli->mts_dependency_order_commits;
check_before_image_consistency= c_rli->check_before_image_consistency;

DBUG_RETURN(0);
}
Expand Down

0 comments on commit 64b9e89

Please sign in to comment.