Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting rows fails to replicate #1174

Closed
ldonoso opened this issue Oct 22, 2021 · 0 comments
Closed

Deleting rows fails to replicate #1174

ldonoso opened this issue Oct 22, 2021 · 0 comments

Comments

@ldonoso
Copy link

ldonoso commented Oct 22, 2021 •
edited

The replication of deleted rows as in:

connection master;
DELETE FROM t1 WHERE C1 = C2;
SELECT * FROM t1 ORDER BY C1,C2;
--source include/sync_slave_sql_with_master.inc
SELECT * FROM t1 ORDER BY C1,C2;

fails with:

T@12: | | | | | | >Rows_log_event::do_scan_and_update
T@12: | | | | | | | info: Hash was populated with 2 records!
T@12: | | | | | | | >Rows_log_event::open_record_scan
T@12: | | | | | | | | info: locating record using a key (index_read)
T@12: | | | | | | | | >handler::ha_index_init
T@12: | | | | | | | | | >virtual int myrocks::ha_rocksdb::index_init(uint, bool)
T@12: | | | | | | | | | <virtual int myrocks::ha_rocksdb::index_init(uint, bool) 10832
T@12: | | | | | | | | <handler::ha_index_init
T@12: | | | | | | | <Rows_log_event::open_record_scan
T@12: | | | | | | | >Rows_log_event::next_record_scan
...
T@12: | | | | | | | <Rows_log_event::next_record_scan
T@12: | | | | | | | >Hash_slave_rows::get
T@12: | | | | | | | | >Hash_slave_rows::make_hash_key
T@12: | | | | | | | | <Hash_slave_rows::make_hash_key
T@12: | | | | | | | <Hash_slave_rows::get
T@12: | | | | | | | >Rows_log_event::next_record_scan
...
T@12: | | | | | | | <Rows_log_event::next_record_scan
T@12: | | | | | | | >Hash_slave_rows::get
T@12: | | | | | | | | >Hash_slave_rows::make_hash_key
T@12: | | | | | | | | <Hash_slave_rows::make_hash_key
T@12: | | | | | | | <Hash_slave_rows::get
T@12: | | | | | | | >Rows_log_event::next_record_scan
T@12: | | | | | | | | >handler::ha_index_next_same
T@12: | | | | | | | | | >virtual int myrocks::ha_rocksdb::index_next_same(uchar*, const uchar*, uint)
T@12: | | | | | | | | | <virtual int myrocks::ha_rocksdb::index_next_same(uchar*, const uchar*, uint) 9225
T@12: | | | | | | | | <handler::ha_index_next_same
T@12: | | | | | | | <Rows_log_event::next_record_scan
T@12: | | | | | | | info: error: HA_ERR_KEY_NOT_FOUND
T@12: | | | | | | | >void handler::print_error
T@12: | | | | | | | | enter: error: 120
T@12: | | | | | | | | >my_error
T@12: | | | | | | | | | >my_message_sql
T@12: | | | | | | | | | | error: error: 1032  message: 'Can't find record in 't1''

Please, find attached test showing the issue: rpl_rocdsdb_row_basic.tar.gz

Probably cause:

ha_rocksdb::index_next_same doesn't play well with Rows_log_event::next_record_scan. ha_rocksdb::index_next_same always fails when m_full_key_lookup is true.

The issue is a regression which might have been introduced in f35c50e
facebook-github-bot pushed a commit that referenced this issue Oct 22, 2021
@lth @facebook-github-bot
Fix incorrect setting of m_full_key_lookup
3a8fccc 
Summary:
This fixes #1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
@lth lth closed this as completed Oct 22, 2021
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Oct 25, 2021
Fix incorrect setting of m_full_key_lookup
51b80d6 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Oct 28, 2021
Fix incorrect setting of m_full_key_lookup
7f5c8f9 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Oct 28, 2021
Fix incorrect setting of m_full_key_lookup
16ba227 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Oct 29, 2021
Fix incorrect setting of m_full_key_lookup
92c5670 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Nov 1, 2021
Fix incorrect setting of m_full_key_lookup
b8dae22 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Nov 1, 2021
Fix incorrect setting of m_full_key_lookup
b6e5843 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Nov 1, 2021
Fix incorrect setting of m_full_key_lookup
cac97fb 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Nov 2, 2021
Fix incorrect setting of m_full_key_lookup
38ff415 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
ldonoso pushed a commit to ldonoso/percona-server that referenced this issue Nov 2, 2021
Fix incorrect setting of m_full_key_lookup
8bb1e94 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Sep 1, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
05837a4 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Sep 1, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
ec57621 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Sep 5, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
724e586 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Sep 7, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
cac7dfe 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Sep 26, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
0c92c95 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Oct 17, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
96e9c1b 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to percona/percona-server that referenced this issue Dec 1, 2022
@inikep
Fix incorrect setting of m_full_key_lookup
78c31b3 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Jan 12, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
368835d 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Jan 16, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
2da8892 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Jan 26, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
9005667 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to percona/percona-server that referenced this issue Feb 10, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
3665cd0 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Apr 14, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
df26849 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Apr 21, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
7bd64e4 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Apr 24, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
b94e390 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Apr 24, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
c742963 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Apr 25, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
5fa5629 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Apr 26, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
dafaeaa 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue May 10, 2023
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
83a5470 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Jun 29, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
a32c734 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Oct 25, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
acf97d8 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Oct 26, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
f7b6a80 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Oct 26, 2023
@inikep
Fix incorrect setting of m_full_key_lookup
7491f38 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Nov 1, 2023
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
1fa1fbd 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Nov 10, 2023
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
e7aa5a9 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Jan 17, 2024
@inikep
Fix incorrect setting of m_full_key_lookup
4f40d1e 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
inikep pushed a commit to inikep/percona-server that referenced this issue Jan 17, 2024
@inikep
Fix incorrect setting of m_full_key_lookup
315d614 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Jan 18, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
45420de 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Jan 21, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
a84ef79 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Jan 26, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
44a4cd2 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Jan 30, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
05d9cb0 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 12, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
e56f443 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 12, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
7d3cd40 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 12, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
d323429 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 15, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
fdc4be0 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 15, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
e33e1a0 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 15, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
1834398 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
08c067f 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
8a5aefc 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
dc1d6cc 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
3adbeab 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
89b7379 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
9da1162 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 16, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
2d610db 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 18, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
192f4cc 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue Apr 29, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
a9db312 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue May 13, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
c1e60cd 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue May 24, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
54a83d1 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this issue May 27, 2024
@oleksandr-kachan
Fix incorrect setting of m_full_key_lookup
e453f0f 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this issue May 31, 2024
@VarunNagaraju
Fix incorrect setting of m_full_key_lookup
95be23a 
Upstream commit ID : fb-mysql-5.6.35/3a8fcccc599b306ed907db6bda107ac3488cf50c
PS-7921 : Merge percona-202105

Percona:
The original commit does not belong to tag percona-202105.
It is a fix for f35c50e, which belongs
to percona-202105.

Summary:
This fixes facebook/mysql-5.6#1174

For secondary keys, it is not sufficient to look at keypart_map to determine whether the full is passed in or not, since the sql layer sometimes passes in `HA_WHOLE_KEY` even when it does not include extended keys.

We already have handling for it, and we only do point lookups when the secondary key includes extended keys as well. However, we were always setting `m_full_key_lookup` even if we end up not doing a point lookup.

Reviewed By: yoshinorim

Differential Revision: D31862865

fbshipit-source-id: be77d1199f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lth @ldonoso