Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the TODO comment on Table_ddl_manager::put #33

Closed
hermanlee opened this issue Sep 28, 2015 · 5 comments
Closed

Address the TODO comment on Table_ddl_manager::put #33

hermanlee opened this issue Sep 28, 2015 · 5 comments
Labels
myrocks

Comments

@hermanlee
Copy link
Contributor

Issue by maykov
Thursday Apr 02, 2015 at 06:35 GMT
Originally opened as MySQLOnRocksDB#50

This function modifies ddl_hash and index_num_to_keydef.
However, these changes need to be reversed if dict_manager.commit fails
See the discussion here: https://reviews.facebook.net/D35925#inline-259167
@hermanlee
Copy link
Contributor Author

Comment by yoshinorim
Wednesday Aug 12, 2015 at 23:52 GMT

@maykov Now MyRocks always aborts if dict_manager.commit() fails. Do we still need to fix this?

@jtolmer jtolmer mentioned this issue Sep 28, 2015
Closed
spetrunia added a commit that referenced this issue Jan 5, 2016
@spetrunia @jtolmer
Issue #33: SELECT ... FROM rocksdb_table ORDER BY primary_key uses so…
19b5f58 
…rting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Test Plan: mtr

Reviewers: maykov, jonahcohen, hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: jtolmer

Differential Revision: https://reviews.facebook.net/D33957
@alxyang
Copy link
Contributor

alxyang commented Feb 25, 2016

came across this comment, while working on inplace alter table. Are we still planning to fix this? Can I assume that dict_manager.commit will not fail (or if it does, MyRocks will abort anyways)

@hermanlee
Copy link
Contributor Author

I think there is probably enough functionality depending on dict_manager.commit() succeeding that if it fails, MyRocks needs to abort. So you can depend on this requirement. Do others feel this is the case?

@yoshinorim
Copy link
Contributor

MyRocks aborts on dict_manager.commit() errors and we are unlikely to change it. So you can rely on it.

@alxyang
Copy link
Contributor

alxyang commented Feb 25, 2016

ok, sounds good.

hermanlee pushed a commit that referenced this issue Jan 31, 2017
@spetrunia
Issue #33: SELECT ... FROM rocksdb_table ORDER BY primary_key uses so…
311668b 
…rting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Test Plan: mtr

Reviewers: maykov, jonahcohen, hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: jtolmer

Differential Revision: https://reviews.facebook.net/D33957
VitaliyLi pushed a commit to VitaliyLi/mysql-5.6 that referenced this issue Feb 9, 2017
@spetrunia @jkedgar
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
cc760b8 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Test Plan: mtr

Reviewers: maykov, jonahcohen, hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: jtolmer

Differential Revision: https://reviews.facebook.net/D33957
facebook-github-bot pushed a commit that referenced this issue Dec 23, 2019
@spetrunia @facebook-github-bot
Issue #33: SELECT ... FROM rocksdb_table ORDER BY primary_key uses so…
6c106c8 
…rting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 0eb822e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 12, 2020
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
77c0f4b 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 0eb822e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 9, 2020
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
80fe11e 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 0eb822e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 16, 2020
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
1b5ae4b 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 0eb822e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Oct 5, 2020
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
1d0b2c3 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 0eb822e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Nov 11, 2020
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
cdbd8ae 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 0eb822e
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Mar 11, 2021
@spetrunia @facebook-github-bot
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
80dd8d1 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 06281bdcc18
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 16, 2021
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
d7c96e4 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 06281bdcc18
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Aug 30, 2021
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
fe63863 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 06281bdcc18
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 1, 2021
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
676dc83 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 06281bdcc18
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Sep 2, 2021
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
feaf756 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957

fbshipit-source-id: 06281bdcc18
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jan 17, 2022
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
ce9b652 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Apr 26, 2022
@spetrunia
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
49b158d 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957
laurynas-biveinis pushed a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 11, 2022
@spetrunia
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
c94803a 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 1, 2023
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
6f1fab6 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 14, 2023
@spetrunia @inikep
Issue facebook#33: SELECT ... FROM rocksdb_table ORDER BY primary_key…
592db88 
… uses sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Differential Revision: https://reviews.facebook.net/D33957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
myrocks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yoshinorim @alxyang @hermanlee