Drop react native debugger support

Summary:
Changelog:
Based on low internal usage and feedback of low usage outside Facebook, we are dropping react native debugger support from Nuclide.
That'd enable us to improve Nuclide's debugger quality first and later, add proper React Native debugging support.

Reviewed By: ebluestein

Differential Revision:
D5278779

Tags: nuclide, nuclide-debugger

fbshipit-source-id: a3c308d85a91c447c28a7b69045314ba1de1bcb4

docs/_docs/features/debugger.md

@@ -194,7 +194,6 @@ language specific debugging workflows that require discussion and illustration.
 
 ## Platform Specific Debugging
 
-- [React Native](/docs/platforms/react-native/#debugging)
 - [iOS](/docs/platforms/ios/#debugging)
 - [Android](/docs/platforms/android/#debugging)
 

docs/_docs/languages/objective-c.md

@@ -138,8 +138,7 @@ the implementation (i.e., `.cpp` or `.m`) files.
 
 ## Debugging
 
-Nuclide has support for both [iOS](/docs/platforms/ios) debugging through
-[React Native](/docs/platforms/react-native/#debugging) and [Buck](http://buckbuild.com)
+Nuclide has support for [iOS](/docs/platforms/ios) debugging and [Buck](http://buckbuild.com)
 for native Objective-C applications (i.e., `.m` files).
 
 > Debugging Swift applications is currently not supported.

docs/_docs/platforms/ios.md

@@ -44,8 +44,6 @@ Nuclide supports the [Buck](https://buckbuild.com/) build system. See the
 Debugging native [Objective-C](/docs/languages/objective-c/) iOS applications is
 [supported using Buck](/docs/features/buck/#debug).
 
-> [React Native](/docs/platforms/react-native/#debugging) is also supported.
-
 ## Simulator Logs
 
 When running your iOS project in the iOS simulator, you can open and view the simulator logs

docs/_docs/platforms/react-native.md

@@ -32,13 +32,11 @@ If your React Native apps are primarily written in [Flow](/docs/languages/flow),
 
 All React Native features are currently available from the [Command Palette](/docs/editor/basics/#command-palette).
 
-![](/static/images/docs/platform-react-native-debugging-command-palette.png)
-
 You run the React Native Packager and Server from Nuclide and your application from the command line.
 
 ### React Native Packager
 
-From the [Command Palette](/docs/editor/basics/#command-palette), choose `Nuclide React Native: Start Packager` to start the React Native Server. The output in the [Console](/docs/features/debugger/#basics__evaluation) panel indicates if the React Native Packager started or if it encountered any errors.
+From the [Command Palette](/docs/editor/basics/#command-palette), choose `Nuclide React Native: Start Packager` to start the React Native Server. The output in the `Console` panel indicates if the React Native Packager started or if it encountered any errors.
 
 ![](/static/images/docs/platform-react-native-start-packager.png)
 
@@ -55,16 +53,11 @@ $ react-native run-android
 
 This should bring up the Simulator with your running application inside.
 
-## Debugging
-
-[React Native](https://facebook.github.io/react-native/) for [iOS](/docs/platforms/ios) has
-first-class support within Nuclide. The Debugger is no exception.
+## Support
 
-> Debugging React Native for Android is currently not supported except for the
-> [Simulator logs](#simulator-logs).
+Nuclide has support for [React Native](https://facebook.github.io/react-native/) for [iOS](/docs/platforms/ios).
 
-From Nuclide, you can start a React Native development server, inspect React Native elements and
-use the [Debugger](/docs/features/debugger#basics) to set and stop on breakpoints, etc.
+From Nuclide, you can start a React Native development server, inspect React Native elements.
 
 > In order to use React Native within Nuclide, you must
 > [install](https://facebook.github.io/react-native/docs/getting-started.html) it.
@@ -78,55 +71,15 @@ from the root of your project.
 
 ### React Native Server
 
-Before starting the Debugger, [launch the React Native Server from within Nuclide](#running-applications__react-native-packager).
-
-### Prime the Debugger
-
-After starting the server, you can prime the React Native Debugger for when the application begins
-running. From the [Command Palette](/docs/editor/basics/#command-palette), launch
-`Nuclide React Native: Start Debugging`.
-
-You might see that the Nuclide Debugger UI appears but doesn't start, instead showing you a waiting condition.
-
-<img src="/static/images/docs/platform-react-native-debugger-waititng.png" align="middle" style="width:500px" />
-
-This means that the Debugger is waiting to attach to the actual running process of the React
-Native application.
+[Launch the React Native Server from within Nuclide](#running-applications__react-native-packager).
 
 ### Run the React Native Application
 
 [Start your React Native application from the command-line](#running-applications__command-line).
 
-### Enable Debugging from the Application
-
-From the Simulator, you will want to enable debugging the application. Press `Cmd-D` (`Ctrl-D` on
-Linux). This will bring up the debug options for your application. Select **Debug JS Remotely**.
-
-![](/static/images/docs/platform-react-native-debug-options.png)
-
-> If you have enabled debugging in a previous session, then debugging will still be enabled; thus,
-> this step will not be necessary.
-
-### Start Debugging
-
-After you enable debugging from the simulated application, Nuclide will attach to that debugging
-process automatically, since we primed the Debugger above. You can now set breakpoints, Watch Expressions,
-etc.
-
-> You can set breakpoints, Watch Expressions, etc. earlier than this step, but access to them will not be
-> available until the debugging has been enabled.
-
-> If the Debugger is paused when it opens, you may have to click the resume execution button
-> (i.e., the play icon) for debugging to begin.
-
-Now you can start debugging your React Native application as [normal](/docs/features/debugger#basics).
-
-![](/static/images/docs/platform-react-native-debugging.png)
-
 ### Element Inspector
 
-The React Native Debugger in Nuclide also provides an Element Inspector, where you can view and
-toggle properties of your application.
+Nuclide provides an Element Inspector, where you can view and toggle properties of your application.
 
 From the [Command Palette](/docs/editor/basics/#command-palette), choose `Nuclide React Native Inspector: Show` to open the **React Native Inspector** tab in the
 main [Editing Area](/docs/editor/basics/#editing-area).

pkg/nuclide-react-native/lib/Activation.js

@@ -12,19 +12,16 @@
 import type {OutputService} from '../../nuclide-console/lib/types';
 import type {CwdApi} from '../../nuclide-current-working-directory/lib/CwdApi';
 
-import {DebuggingActivation} from './debugging/DebuggingActivation';
 import {PackagerActivation} from './packager/PackagerActivation';
 import {ShellActivation} from './shell/ShellActivation';
 import {CompositeDisposable} from 'atom';
 
 export default class Activation {
-  _debuggingActivation: DebuggingActivation;
   _packagerActivation: PackagerActivation;
   _disposables: IDisposable;
 
   constructor(state: ?Object) {
     this._disposables = new CompositeDisposable(
-      (this._debuggingActivation = new DebuggingActivation()),
       (this._packagerActivation = new PackagerActivation()),
       new ShellActivation(),
     );