git-diff is disabled, no diff gutters

[IanVS]

Issue and Steps to Reproduce

It seems that nuclide disables git-diff, and so I no longer am getting diff gutters, which I find to be really useful.

Expected Behavior

I should see colors in the gutter indicating whether a line is removed, added, or changed.

Actual Behavior

I get no indications.

Versions

• Atom: 1.32.0-beta1
• Nuclide: 0.354.0
• Client OS: macOS

[sintylapse]

The same thing for me. I used to enable git-diff manually, but after some time it disabled again

[IanVS]

@tjfryan it looks like you reviewed 78255d8 which removed git-diff, and 405805a which seems to attempt to add new ones? But it seems the new ones aren't working, is there something we have to do to turn them on? I can't find Shan Phylim (who made the commits) in github… Unless maybe it's @shanpls?

[shanpls]

@IanVS This will be fixed in the next release

[IanVS]

This doesn't seem to be fixed in 0.362.0, I still don't have git diff gutters.

[ghost]

Yeah definitely still not fixed

[Boboss74]

I miss git diff gutters 😭

[Boboss74]

@shanpls still not fixed in 0.366.0 :/

[IanVS]

@Boboss74 that's strange, it seems to be working for me in 0.366.0. I restarted atom, and git-diff is still enabled (I've been manually enabling it each time I restart atom).

[Boboss74]

@IanVS
You can see the gutters ? :o

[Boboss74]

It's working !

I removed the followed git-diff lines in my ~/.atom/config.cson

"*":
  core:
    disabledPackages: [
	  "git-diff"
	]
    packagesWithKeymapsDisabled: [
      "git-diff"
    ]

Shame on me T-T

[sintylapse]

thanks, @Boboss74 , it worked. Maybe after some nuclide updates this settings were persisted