Separate preferences from plist and add user-concept #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
|
@theopolis updated the pull request - view changes |
theopolis
force-pushed
the
preferences_plist_2
branch
from
cdc2220
to
f49a185
Compare
|
@theopolis updated the pull request - view changes |
|
Fixes: #3083 |
|
ok to test |
|
@theopolis updated the pull request - view changes |
|
@theopolis updated the pull request - view changes |
muffins
pushed a commit
to muffins/osquery
that referenced
this pull request
Jul 8, 2017
This was referenced Jul 17, 2017
trizt
pushed a commit
to trizt/osquery
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the overloaded use of the
preferencestable.preferencesacts likedefaultson macOS. It is limited in that it cannot join users or report the system's defaults. In the current form it can also take anypathinput and report the flattened plist items.This separates the defaults, keeping the functionality in
preferencesfrom theplist(a new table) functions.