Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bundle C++ extensions into a single executable #4335
This PR adds a new CMake function (add_osquery_extension_ex) that can be used to declare extension targets that will eventually get compiled into a single executable.
The executable name and version can be changed using the following two environment variables:
If they are not present, the executable will be called
How it works
First of all, old behavior is not modified in any way; extensions will have to be slightly modified to make use of this functionality. The two approaches can be mixed and will not conflict.
The new add_osquery_extension_ex() function aggregates all extension targets into global project properties. Once the
referenced this pull request
Apr 27, 2018
Seems like a neat feature! I haven't read all of the
changed the title from
WIP: Bundle C++ extensions into a single executable
Bundle C++ extensions into a single executable
May 1, 2018
Hi, @alessandrogario, Is it still in progress?
I feel like this is complete and ready for review (thanks for looking at this!)
I'm not really sure about the idea of merging extensions and osqueryd into a single executable, as I never really thought about this use case.
We are maintaining an extension repository so we felt the need of bundling them together to make them easier to use, but we will keep using the official packages. One thing that I really like is that the maintainers are doing an awesome job at keeping the release quality high, so my preference would still be to avoid grouping extensions and core into a single executable.
This may be really interesting for other user cases though (especially for heavy osqueryi users).