Adding ability to monitor whole folders #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,6 +127,10 @@ Status listDirectoriesInDirectory(const boost::filesystem::path& path, | |||
| Status resolveFilePattern(const boost::filesystem::path& fs_path, | |||
| std::vector<std::string>& results); | |||
|
|
|||
| Status resolveFilePattern(const boost::filesystem::path& fs_path, | |||
There was a problem hiding this comment.
can you add a doxygen comment indicating what setting is for?
|
looks good other than those two comments. |
| @@ -245,10 +244,15 @@ Status doubleStarTraversal(const boost::filesystem::path& fs_path, | |||
| */ | |||
| Status resolveLastPathComponent(const boost::filesystem::path& fs_path, | |||
| std::vector<std::string>& results, | |||
| unsigned int setting, | |||
obelisk
force-pushed
the
directory_monitoring
branch
from
1a6e26f
to
70c82b5
Compare
Fixed a bug where when using REC_LIST_FOLDERS, the root resolution directory would not be returned.
obelisk
added
ready for review
| EXPECT_EQ(files["system_binaries"].size(), 5); | ||
| EXPECT_EQ(files["downloads"].size(), 1); | ||
| for (const auto& file : files["system_binaries"]) { | ||
| std::cout << file << "\n"; |
| @@ -59,7 +59,9 @@ void FileChangesEventSubscriber::init() { | |||
|
|
|||
| for (const auto& element_kv : file_map) { | |||
| for (const auto& file : element_kv.second) { | |||
| VLOG(1) << "Added Listener To: " << file; | |||
There was a problem hiding this comment.
You Don't Need To Cap Every Word :)
obelisk
added a commit
that referenced
this pull request
Mar 3, 2015
Adding ability to monitor whole folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.