This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix duplicate edges issue in Prepack heap visualization #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreytan81
requested review from
cblappert,
hermanventer,
NTillmann and
j-nolan
jeffreytan81
force-pushed
the
ImprovePrepackGraphVisualization
branch
from
51b9447
to
cbca87f
Compare
NTillmann
approved these changes
Jan 3, 2018
jeffreytan81
force-pushed
the
ImprovePrepackGraphVisualization
branch
from
d22d49f
to
22d930a
Compare
|
No, currently, if there is a bug in the visualization(Vis.js bug or graph data format not valid), it won't break down the whole website. It's just the "Show Heap" button shows no content(not sure if this can be improved with some error message). The serialized code will still show.(At least this is true for this bug). |
There was a problem hiding this comment.
@yinghuitan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note: Fix duplicate edges issue in Prepack heap visualization.
This PR did two things: