Fix flow cycle issue

facebookarchive · Jan 3, 2018 · 22d930a · 22d930a
1 parent cbca87f
commit 22d930a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/src/options.js b/src/options.js
@@ -9,7 +9,6 @@
 
 /* @flow */
 
-import type { HeapGraphFormat } from "./types";
 import type { ErrorHandler } from "./errors.js";
 
 export type Compatibility = "browser" | "jsc-600-1-4-17" | "node-source-maps" | "node-cli" | "react-mocks";
@@ -48,7 +47,7 @@ export type SerializerOptions = {
   inlineExpressions?: boolean,
   simpleClosures?: boolean,
   trace?: boolean,
-  heapGraphFormat?: HeapGraphFormat,
+  heapGraphFormat?: "DotLanguage" | "VISJS",
 };
 
 export type PartialEvaluatorOptions = {

diff --git a/src/prepack-options.js b/src/prepack-options.js
@@ -9,7 +9,6 @@
 
 /* @flow */
 
-import type { HeapGraphFormat } from "./types";
 import type { ErrorHandler } from "./errors.js";
 import type { SerializerOptions, RealmOptions, Compatibility, DebuggerOptions, ReactOutputTypes } from "./options";
 import { Realm } from "./realm.js";
@@ -20,7 +19,7 @@ export type PrepackOptions = {|
   additionalFunctions?: Array<string>,
   abstractEffectsInAdditionalFunctions?: boolean,
   lazyObjectsRuntime?: string,
-  heapGraphFormat?: HeapGraphFormat,
+  heapGraphFormat?: "DotLanguage" | "VISJS",
   compatibility?: Compatibility,
   debugNames?: boolean,
   delayInitializations?: boolean,

diff --git a/src/serializer/ResidualHeapGraphGenerator.js b/src/serializer/ResidualHeapGraphGenerator.js
@@ -14,7 +14,6 @@ import type { Modules } from "./modules.js";
 import type { Realm } from "../realm.js";
 import type { ObjectRefCount, AdditionalFunctionEffects } from "./types.js";
 import type { ResidualHeapValueIdentifiers } from "./ResidualHeapValueIdentifiers";
-import type { HeapGraphFormat } from "../types";
 
 import invariant from "../invariant.js";
 import {
@@ -198,7 +197,7 @@ export class ResidualHeapGraphGenerator extends ResidualHeapVisitor {
     return shape;
   }
 
-  generateResult(heapGraphFormat: HeapGraphFormat): string {
+  generateResult(heapGraphFormat: "DotLanguage" | "VISJS"): string {
     return heapGraphFormat === "DotLanguage"
       ? this._generateDotGraphData(this._visitedValues, this._edges)
       : this._generateVisJSGraphData(this._visitedValues, this._edges);

diff --git a/src/types.js b/src/types.js
@@ -997,6 +997,3 @@ export type ToType = {
   // ECMA262 7.1.16
   CanonicalNumericIndexString(realm: Realm, argument: StringValue): number | void,
 };
-
-// VIS.JS is used by https://prepack.io REPL to visualize the graph.
-export type HeapGraphFormat = "DotLanguage" | "VISJS";