This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Special case conditionals for $Set operations on abstract object #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the simplifier do it work and allows intermediate objects to be dead code eliminated. If this looks good, I'll do $SetPartial and $Delete too.
sebmarkbage
commented
Jul 6, 2018
src/values/AbstractObjectValue.js
Outdated
| let d1 = ob1.$GetOwnProperty(P); | ||
| let d2 = ob2.$GetOwnProperty(P); | ||
| let oldVal1 = | ||
| d1 === undefined ? this.$Realm.intrinsics.undefined : IsDataDescriptor(this.$Realm, d1) ? d1.value : undefined; |
There was a problem hiding this comment.
This is not right. Should be empty, not undefined. I'll add a test.
sebmarkbage
commented
Jul 6, 2018
| @@ -0,0 +1,13 @@ | |||
| // does not contain:unnecessaryIndirection | |||
There was a problem hiding this comment.
This is what is different with this diff. The intermediate objects are now eliminated.
sebmarkbage
commented
Jul 9, 2018
| invariant(ob1 instanceof ObjectValue || ob1 instanceof AbstractObjectValue); | ||
| invariant(ob2 instanceof ObjectValue || ob2 instanceof AbstractObjectValue); | ||
| let d1 = ob1.$GetOwnProperty(P); | ||
| let d2 = ob2.$GetOwnProperty(P); |
There was a problem hiding this comment.
Found an existing bug. These don't consider setters on the prototype chain. #2226
hermanventer
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
@sebmarkbage is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the simplifier do it work and allows intermediate objects to be dead code eliminated.
If this looks good, I'll do $SetPartial and $Delete too.