Giving choice - npm or yarn. #786
Conversation
There was a problem hiding this comment.
Not sure where to go from here. If we want to support both npm and yarn, we have to keep the npm run calls in our package.json. Otherwise we could disallow npm and change all of those to yarn run. Keeping things how they are works with both feels a little odd to me because yarn run validate will run all of its scripts with npm.
README.md
Outdated
|
|
||
| ```bash | ||
| $ yarn global add prepack | ||
| $ npm install -g yarn |
There was a problem hiding this comment.
This installs yarn not prepack, npm install -g prepack installs prepack
|
Updated README. Using npm for using Prepack should be fine. You only need all the scripts for further development work. I added a note describing that. |
|
In this case we should also change the |
Pointing out that yarn is not optional for development work as many scripts require it.
|
Okay, you one really needs yarn to develop. |
|
@NTillmann has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Fixing issue raised in #782.