Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING and CODE_OF_CONDUCT #140

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Conversation

flarnie
Copy link
Contributor

@flarnie flarnie commented Nov 23, 2017

what is the change?:
Even though this is a small project and we don't expect changes, it's
standard to include a CONTRIBUTING.md and CODE_OF_CONDUCT.md doc.

why make this change?:
Let's give folks info about how to contribute, to foster a welcoming open source community in the React ecosystem.

Exposing the COC via a separate markdown file is a standard being
promoted by Github via the Community Profile in order to meet their Open
Source Guide's recommended community standards.

As you can see, adding this file will improve the prop-types Community Profile
checklist and increase the visibility of our COC.

test plan:
Viewing it on my branch -
screen shot 2017-11-23 at 12 15 50 pm
screen shot 2017-11-23 at 12 16 08 pm

issue:
internal task t23481323

**what is the change?:**
Even though this is a small project and we don't expect changes, it's
standard to include a `CONTRIBUTING.md` doc.

**why make this change?:**
Let's give folks info about how to contribute, to foster a welcoming
open source community in the React ecosystem.

**test plan:**
Viewing this file on my branch.

**issue:**
T23481323
**what is the change?:**
Adding a document linking to the Facebook Open Source Code of Conduct,
for visibility and to meet Github community standards.

**why make this change?:**
Facebook Open Source provides a Code of Conduct statement for all
projects to follow.

Exposing the COC via a separate markdown file is a standard being
promoted by Github via the Community Profile in order to meet their Open
Source Guide's recommended community standards.

As you can see, adding this file will improve the [prop-types Community Profile](https://github.com/facebook/prop-types/community)
checklist and increase the visibility of our COC.

**test plan:**
Viewing it on my branch -
(Flarnie will insert screenshots)

**issue:**
internal task t23481323
@bvaughn bvaughn merged commit 644844c into facebook:master Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants