This repository has been archived by the owner on Sep 1, 2024. It is now read-only.
Updated all vars in test files to consts and lets. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 19, 2018 15:33
ljharb
suggested changes
Mar 19, 2018
|
Doesn't the babel preset sort that out? |
|
In the test files, i suppose, but none of the production files in this repo get run through babel. |
|
Ah right, didn't realize that. I'll update the PR to only update the tests. |
|
There we go, I reset back to the commits that only affect the test files 👍 |
|
Seems fine, thanks. A PR adding a Babel step would also be great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to define variables as consts and lets over vars.