Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract has and warning #261

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
3 participants
@noscripter
Copy link
Contributor

noscripter commented Feb 27, 2019

According to DRY, extract has and warning message to lib as well as making the failing tests pass.

Show resolved Hide resolved checkPropTypes.js Outdated
Show resolved Hide resolved checkPropTypes.js Outdated
Show resolved Hide resolved factoryWithTypeCheckers.js Outdated
Show resolved Hide resolved checkPropTypes.js Outdated
Show resolved Hide resolved checkPropTypes.js Outdated
Show resolved Hide resolved __tests__/PropTypesDevelopmentStandalone-test.js Outdated
@ljharb
Copy link
Collaborator

ljharb left a comment

The PR might need to be rebased.

Show resolved Hide resolved __tests__/PropTypesDevelopmentStandalone-test.js Outdated

@ljharb ljharb force-pushed the noscripter:extract_has branch from 5d5d2e3 to e32c490 Mar 3, 2019

@ljharb

ljharb approved these changes Mar 3, 2019

@ljharb ljharb merged commit e32c490 into facebook:master Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.