Add caching to configurationless migration #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57681433 |
|
This pull request was exported from Phabricator. Differential Revision: D57681433 |
stroxler
pushed a commit
that referenced
this pull request
May 23, 2024
Summary: Pull Request resolved: #866 This diff adds functionality around caching operations determining which files are included in a given .pyre_configuration.local. Determining which files are included can be expensive. We need to perform operations to determine the following: * What are all files that can be included in this configuration? We ask `hg` (or perform a glob) for this * What are all files that should be excluded from this configuration? * What are all files included in nested configurations where those configurations should have priority over this one? We perform the first step in this list once for each nested configuration. The steps above are performed once for each file we're linting, so determining which files should be included is an expensive process. We attempt to mitigate it by caching a lot of these operations. Differential Revision: D57681433
stroxler
force-pushed
the
export-D57681433
branch
from
8f74ad3
to
7ca5f54
Compare
Summary: This diff adds functionality around caching operations determining which files are included in a given .pyre_configuration.local. Determining which files are included can be expensive. We need to perform operations to determine the following: * What are all files that can be included in this configuration? We ask `hg` (or perform a glob) for this * What are all files that should be excluded from this configuration? * What are all files included in nested configurations where those configurations should have priority over this one? We perform the first step in this list once for each nested configuration. The steps above are performed once for each file we're linting, so determining which files should be included is an expensive process. We attempt to mitigate it by caching a lot of these operations. Reviewed By: MaggieMoss Differential Revision: D57681433
stroxler
force-pushed
the
export-D57681433
branch
from
7ca5f54
to
ae0fda1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681433 |
|
This pull request has been merged in 573e772. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds functionality around caching operations determining which files are included in a given .pyre_configuration.local.
Determining which files are included can be expensive. We need to perform operations to determine the following:
hg(or perform a glob) for thisThe steps above are performed once for each file we're linting, so determining which files should be included is an expensive process. We attempt to mitigate it by caching a lot of these operations.
Differential Revision: D57681433