Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

The sidebar doesn't show up in Canary #29

Closed
sebmarkbage opened this issue Mar 8, 2014 · 8 comments
Closed

The sidebar doesn't show up in Canary #29

sebmarkbage opened this issue Mar 8, 2014 · 8 comments

Comments

@sebmarkbage
Copy link
Contributor

Using Chrome Canary, the sidebar is gone. Might be a breaking change coming or just a temporary bug in Canary.

@sophiebits
Copy link
Contributor

(Also in Beta channel, so probably hitting release channel soon.)

@sanatgersappa
Copy link

Dev Channel as well.

sophiebits added a commit to sophiebits/react-devtools that referenced this issue Mar 8, 2014
See facebook#29.

I updated blink-devtools to the latest (requires sebmarkbage/blink-devtools#1) and did a manual merge, changing ReactPanel.js to match all changes that happened to ElementPanel.js since the last devtools version.

I'm not sure we actually want to continue tracking the latest devtools; we could presumably keep an old version of the panels and just fix the specific problem with the removed SidebarView.

This doesn't actually work properly yet due to some style-related bug; when the panel is rendered, the View components read all of their dimensions as 0, then 0 is set as the actual width and height of each element, causing nothing to display. However, if the script debugger is used within `ReactPanel.show` to inspect `this.element` (but not to change any properties on it), then the panel seems to display correctly. I'm not sure how to go about fixing this. I can look more later, but if anyone has ideas here I'd appreciate it.
@sophiebits
Copy link
Contributor

I worked on this some in #30 but there's some odd style-related bug that I'm having trouble tracking down.

@sebmarkbage
Copy link
Contributor Author

I can't repro this anymore. Has this been fixed in Chrome? @joshduck

@sanatgersappa
Copy link

Same here. Works fine now.

@sunify
Copy link

sunify commented May 20, 2014

Chrome 34.0.1847.137
No tab — http://d.pr/i/uKUm

@coodoo
Copy link

coodoo commented May 22, 2014

Any update on this? Using 37.0.2007.2 canary and can't seem to make react devtools working.

@zpao
Copy link
Member

zpao commented Jun 19, 2014

WFM

@zpao zpao closed this as completed Jun 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants