This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix missing sidebar in Chrome 34 and later #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See facebook#29. I updated blink-devtools to the latest (requires sebmarkbage/blink-devtools#1) and did a manual merge, changing ReactPanel.js to match all changes that happened to ElementPanel.js since the last devtools version. I'm not sure we actually want to continue tracking the latest devtools; we could presumably keep an old version of the panels and just fix the specific problem with the removed SidebarView. This doesn't actually work properly yet due to some style-related bug; when the panel is rendered, the View components read all of their dimensions as 0, then 0 is set as the actual width and height of each element, causing nothing to display. However, if the script debugger is used within `ReactPanel.show` to inspect `this.element` (but not to change any properties on it), then the panel seems to display correctly. I'm not sure how to go about fixing this. I can look more later, but if anyone has ideas here I'd appreciate it.
|
Seems to be working in latest Chrome again, so I'll close this out for now… sounds like we probably will want to track blink devtools but we'll cut at a release in hopes that it'll be more stable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29.
I updated blink-devtools to the latest (requires sebmarkbage/blink-devtools#1)
and did a manual merge, changing ReactPanel.js to match all changes that
happened to ElementPanel.js since the last devtools version.
I'm not sure we actually want to continue tracking the latest devtools; we
could presumably keep an old version of the panels and just fix the specific
problem with the removed SidebarView.
This doesn't actually work properly yet due to some style-related bug; when
the panel is rendered, the View components read all of their dimensions as 0,
then 0 is set as the actual width and height of each element, causing nothing
to display. However, if the script debugger is used within
ReactPanel.showto inspect
this.element(but not to change any properties on it), then thepanel seems to display correctly. I'm not sure how to go about fixing this. I
can look more later, but if anyone has ideas here I'd appreciate it.