This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
[Electron] Remove indirection #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to eval the backend because we can just import it.
jaredly
reviewed
Feb 9, 2017
| hasClosed = true; | ||
| setTimeout(() => { | ||
| connectToDevTools(options); | ||
| }, 2000); |
There was a problem hiding this comment.
we might want to drop this to 500 -- 2 seconds feels like a long time to wait for reconnection
There was a problem hiding this comment.
This was intentional change from RN team because they had some issues with 200ms reconnection (it was making things slow or something). 500ms is better than 200ms but I don't want to touch it without understanding the issues they had in the first place. Maybe @yungsters or @javache can provide more details.
pastelsky
pushed a commit
to pastelsky/react-devtools
that referenced
this pull request
Feb 25, 2017
* Remove the `eval` indirection There is no need to eval the backend because we can just import it. * Unify "backend" and "embed" into one file * Bump ws dep * Fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vastly simplifies the Electron shell.
Changes:
evaldance and merge backend and embed together