Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation indicator and deprecation notes standardization #1493

Merged
merged 3 commits into from Feb 7, 2020

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Dec 3, 2019

By deprecation notes standardization I have meant following changes:

  • using current NPM package name
  • using similar phrasing
  • positioning deprecation note always on the top of the page

The rest of changes are basically a concept, which you might not like.

I was aiming to clarify deprecation and discourage developers to use those parts of RN so I have added 🚧emoji to the title of pages marked as deprecated Component or API. (Of course I'm open to change selected emoji, this could be anything else.)

Screenshot 2019-12-03 at 14 59 41

I can work further on this PR or on any other solution that help in the case mentioned above.

@react-native-bot
Copy link

react-native-bot commented Dec 3, 2019

Deploy preview for react-native ready!

Built with commit 182d799

https://deploy-preview-1493--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 9269e76

https://deploy-preview-1493--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@rachelnabors rachelnabors added the Design For things that change the design, CSS, layout, etc of the site. Needs testing in multiple browsers label Dec 3, 2019
@rachelnabors rachelnabors self-assigned this Dec 3, 2019
@Simek Simek mentioned this pull request Dec 9, 2019
@Simek
Copy link
Collaborator Author

Simek commented Dec 9, 2019

@rachelnabors I can extract deprecation standardization changes to separate PR if this helps merge them sooner than indicator proposal.

@Simek
Copy link
Collaborator Author

Simek commented Dec 11, 2019

@hramos I can't request PR review but maybe you will have any feedback for me?

@rachelnabors
Copy link
Contributor

Hi hi! Thanks for working on this. I love it! Can you do ProgressViewIOS and ProgressBarAndroid as well?

@Simek
Copy link
Collaborator Author

Simek commented Feb 6, 2020

@rachelnabors I have updated both pages. Hope I have used the right community repos for those components.

@rachelnabors rachelnabors merged commit 1f09829 into facebook:master Feb 7, 2020
espipj pushed a commit to espipj/react-native-website that referenced this pull request Feb 8, 2020
…#1493)

* deprecation indicator and deprecation notes standardization

* update few more pages

* update ProgressBarAndroid and ProgressViewIOS
kaioduarte pushed a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
…#1493)

* deprecation indicator and deprecation notes standardization

* update few more pages

* update ProgressBarAndroid and ProgressViewIOS
@Simek Simek deleted the deprecation-standardization branch January 26, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design For things that change the design, CSS, layout, etc of the site. Needs testing in multiple browsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants