Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide to creating a New Architecture app from template #3056
Guide to creating a New Architecture app from template #3056
Changes from 26 commits
06a3766
f6aff0d
e7446f2
be2eb18
8754e60
a93abdd
5e9a0d9
a1463d8
77dd04d
7e0ccf0
e98f1b1
86a434c
3854b96
2105e4f
ea370fb
eaa0ee2
7ea7ef0
02a9b4e
f845267
c0a3d43
d5bc865
eea036b
f5e1324
aada4dc
df4c17e
9e06f9d
cbb01bc
1ea529b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my future reference, is there a particular reason you want to go with
caution
here? I went withnote
for any that just add extra info, since it felt like a lot of yellow blocks on the page otherwise, very visually busy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, note/info box are blue and white. They can slip and the user may not notice them. I think that they are good for additional information that, even if the users don't read them, the output doesn't change very much.
A caution box is yellow, and harder to miss. I think we should use it every time we are delivering information that, if missed, may generate some trouble. For example, if the users configure the New Architecture on version 0.67, they will incur in a lot of errors. And it could be tricky to spot that they are using the wrong version. Hence, the yellow box.
Similarly, if the skipped the
Settings Up Your Environment
guide because they are used to work with Expo and they try to use the New Architecture, it won't work, and a yellow box could catch their attention more easily.Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have a different opinion about how this would be read -- for me, too many yellow boxes can visually interfere with the ability to skim the page's structure -- but it's a matter of opinion, so happy to stick with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.