-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tabs now support deep-linking #3619
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
|
ca9ca20
to
f9b4550
Compare
Answering out of order @motiz88:
No it doesn't fix that, just enables updating the query string when interacting (or the page if directly linked with the query string parameters set). Interestingly there's some other work that I have to follow up with here to scroll after load & update the tabs (some of the FYI our CLI has a draft PR using this react-native-community/cli#1870
The change is automated and pretty low risk (IMHO). The CLI change means we'd want to update all of our supported versions (0.71, 0.70, 0.69). The win for our DX is significant enough that I think it's worth figuring out a way to make this more digestible for review. Maybe I can just break out next + 0.71 as part of this to decrease the review burden? |
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, assuming you've done a spot check that the old versions still work after this change.
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620
* feat: add deeplinks to our documentation These changes will only start to work once our documentation is updated to support this feature: - facebook/react-native-website#3618 - facebook/react-native-website#3619 - facebook/react-native-website#3620 * refactor: decouple our version checks There was a single version check that would log an available stable version of React Native that was greater than the current version in a project. The change breaks that up into: - what is the current version - what is the next stable upgrade if available - log any stable upgrade if available
Adds support for deep-linking in tabs. This will only work after #3618 goes it (note: it won't break anything if it does land before).
I updated all of these using this:
CleanShot.2023-03-10.at.15.52.00.mp4