Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat ids for deeplinks #3620

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Feat ids for deeplinks #3620

merged 3 commits into from
Mar 12, 2023

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Mar 10, 2023

Add deeplink support for: JDK, Android Studio and the Android SDK:

# JDK (it's in there 😀)
gg -l '<h3>Node,' | gsed -i 's/<h3>Node,/<h3 id="jdk">Node,/g'

# Android Studio
gg -l '<h4>1. Install Android ' | xargs gsed -i 's/<h4>1. Install Android/<h4 id="android-studio">1. Install Android/g'

# Android SDK
gg -l '<h4>2. Install the An' | xargs gsed -i 's/<h4>2. Install the An/<h4 id="android-sdk">2. Install the An/g'

These are all deep links used by the CLI on error.

@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 176c328
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/640b78b341b6f50008a97dac
😎 Deploy Preview https://deploy-preview-3620--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

blakef added a commit to blakef/cli that referenced this pull request Mar 10, 2023
These changes will only start to work once our documentation is updated
to support this feature:
- facebook/react-native-website#3618
- facebook/react-native-website#3619
- facebook/react-native-website#3620
@blakef blakef merged commit 6abdda9 into facebook:main Mar 12, 2023
blakef added a commit to blakef/cli that referenced this pull request Mar 16, 2023
These changes will only start to work once our documentation is updated
to support this feature:
- facebook/react-native-website#3618
- facebook/react-native-website#3619
- facebook/react-native-website#3620
@blakef blakef deleted the feat-ids-for-deeplinks branch March 16, 2023 13:23
blakef added a commit to blakef/cli that referenced this pull request Mar 16, 2023
These changes will only start to work once our documentation is updated
to support this feature:
- facebook/react-native-website#3618
- facebook/react-native-website#3619
- facebook/react-native-website#3620
blakef added a commit to blakef/cli that referenced this pull request Mar 17, 2023
These changes will only start to work once our documentation is updated
to support this feature:
- facebook/react-native-website#3618
- facebook/react-native-website#3619
- facebook/react-native-website#3620
blakef added a commit to blakef/cli that referenced this pull request Mar 20, 2023
These changes will only start to work once our documentation is updated
to support this feature:
- facebook/react-native-website#3618
- facebook/react-native-website#3619
- facebook/react-native-website#3620
adamTrz pushed a commit to react-native-community/cli that referenced this pull request Mar 20, 2023
* feat: add deeplinks to our documentation

These changes will only start to work once our documentation is updated
to support this feature:
- facebook/react-native-website#3618
- facebook/react-native-website#3619
- facebook/react-native-website#3620

* refactor: decouple our version checks

There was a single version check that would log an available stable
version of React Native that was greater than the current version in a
project.

The change breaks that up into:
- what is the current version
- what is the next stable upgrade if available
- log any stable upgrade if available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants