Ensure internal builds don't use plugin stubs

Summary: We generate a stub for plugin system, so that TurboModules can work in OSS. Unless the `RN_DISABLE_OSS_PLUGIN_HEADER` define is seet, TurboModules will use the plugin stub. Therefore, for internal builds, we should set this define. Reviewed By: fkgozali, mdvacca Differential Revision: D17789993 fbshipit-source-id: a93735738513457236adb3064b80601053c95dd3
facebook · Oct 7, 2019 · 021a63d · 021a63d
1 parent 72c0390
commit 021a63d
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/Libraries/Blob/RCTBlobPlugins.h b/Libraries/Blob/RCTBlobPlugins.h
@@ -9,8 +9,8 @@
 
 #ifdef RN_DISABLE_OSS_PLUGIN_HEADER
 
-// FB Internal: Plugins.h is autogenerated by the build system.
-#import "Plugins.h"
+// FB Internal: FBRCTBlobPlugins.h is autogenerated by the build system.
+#import "FBRCTBlobPlugins.h"
 
 #else
 

diff --git a/Libraries/CameraRoll/RCTCameraRollPlugins.h b/Libraries/CameraRoll/RCTCameraRollPlugins.h
@@ -9,8 +9,8 @@
 
 #ifdef RN_DISABLE_OSS_PLUGIN_HEADER
 
-// FB Internal: Plugins.h is autogenerated by the build system.
-#import "Plugins.h"
+// FB Internal: FBRCTCameraRollPlugins.h is autogenerated by the build system.
+#import "FBRCTCameraRollPlugins.h"
 
 #else
 

diff --git a/Libraries/Settings/RCTSettingsPlugins.h b/Libraries/Settings/RCTSettingsPlugins.h
@@ -9,8 +9,8 @@
 
 #ifdef RN_DISABLE_OSS_PLUGIN_HEADER
 
-// FB Internal: Plugins.h is autogenerated by the build system.
-#import "Plugins.h"
+// FB Internal: FBRCTSettingsPlugins.h is autogenerated by the build system.
+#import "FBRCTSettingsPlugins.h"
 
 #else
 

diff --git a/Libraries/Vibration/RCTVibrationPlugins.h b/Libraries/Vibration/RCTVibrationPlugins.h
@@ -9,8 +9,8 @@
 
 #ifdef RN_DISABLE_OSS_PLUGIN_HEADER
 
-// FB Internal: Plugins.h is autogenerated by the build system.
-#import "Plugins.h"
+// FB Internal: FBRCTVibrationPlugins.h is autogenerated by the build system.
+#import "FBRCTVibrationPlugins.h"
 
 #else
 

diff --git a/React/CoreModules/BUCK b/React/CoreModules/BUCK
@@ -70,6 +70,7 @@ rn_apple_library(
             name = "ActionSheetManager",
             native_class_func = "RCTActionSheetManagerCls",
         ),
+    plugins_header = "FBCoreModulesPlugins.h",
     preprocessor_flags = OBJC_ARC_PREPROCESSOR_FLAGS + get_debug_preprocessor_flags() + rn_extra_build_flags() + [
         "-DRN_DISABLE_OSS_PLUGIN_HEADER",
     ],

diff --git a/React/CoreModules/CoreModulesPlugins.h b/React/CoreModules/CoreModulesPlugins.h
@@ -9,8 +9,8 @@
 
 #ifdef RN_DISABLE_OSS_PLUGIN_HEADER
 
-// FB Internal: Plugins.h is autogenerated by the build system.
-#import "Plugins.h"
+// FB Internal: FBCoreModulesPlugins.h is autogenerated by the build system.
+#import "FBCoreModulesPlugins.h"
 
 #else