Skip to content

Commit

Permalink
Improve view props and style stuff.
Browse files Browse the repository at this point in the history
Reviewed By: fkgozali

Differential Revision: D5155884

fbshipit-source-id: defdcb7853cdb1c82466ee1dc451fc1b5d80782f
  • Loading branch information
sahrens authored and facebook-github-bot committed Jun 1, 2017
1 parent 05e02b2 commit 1f3140c
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 12 deletions.
23 changes: 17 additions & 6 deletions Libraries/Components/View/ShadowPropTypesIOS.js
Expand Up @@ -8,13 +8,23 @@
*
* @providesModule ShadowPropTypesIOS
* @flow
* @format
*/
'use strict';

var ColorPropType = require('ColorPropType');
var ReactPropTypes = require('React').PropTypes;
const ColorPropType = require('ColorPropType');
const ReactPropTypes = require('prop-types');

var ShadowPropTypesIOS = {
/**
* These props can be used to dynamically generate shadows on views, images, text, etc.
*
* Because they are dynamically generated, they may cause performance regressions. Static
* shadow image asset may be a better way to go for optimal performance.
*
* These properties are iOS only - for similar functionality on Android, use the [`elevation`
* property](docs/viewstyleproptypes.html#elevation).
*/
const ShadowPropTypesIOS = {
/**
* Sets the drop shadow color
* @platform ios
Expand All @@ -24,9 +34,10 @@ var ShadowPropTypesIOS = {
* Sets the drop shadow offset
* @platform ios
*/
shadowOffset: ReactPropTypes.shape(
{width: ReactPropTypes.number, height: ReactPropTypes.number}
),
shadowOffset: ReactPropTypes.shape({
width: ReactPropTypes.number,
height: ReactPropTypes.number,
}),
/**
* Sets the drop shadow opacity (multiplied by the color's alpha component)
* @platform ios
Expand Down
14 changes: 8 additions & 6 deletions website/server/docsList.js
Expand Up @@ -90,18 +90,20 @@ const apis = [
'../Libraries/Vibration/VibrationIOS.ios.js',
];

const stylesWithPermalink = [
'../Libraries/StyleSheet/LayoutPropTypes.js',
'../Libraries/StyleSheet/TransformPropTypes.js',
'../Libraries/Components/View/ShadowPropTypesIOS.js',
];

const stylesForEmbed = [
'../Libraries/Components/View/ViewStylePropTypes.js',
'../Libraries/Text/TextStylePropTypes.js',
'../Libraries/Image/ImageStylePropTypes.js',
];

const stylesWithPermalink = [
'../Libraries/StyleSheet/LayoutPropTypes.js',
'../Libraries/StyleSheet/TransformPropTypes.js',
'../Libraries/Components/View/ShadowPropTypesIOS.js',
'../Libraries/Components/View/ViewPropTypes.js',
...stylesForEmbed,
];

const viewPropTypes = '../Libraries/Components/View/ViewPropTypes.js';

module.exports = {
Expand Down

0 comments on commit 1f3140c

Please sign in to comment.