Skip to content

Commit

Permalink
Remove hack in C++ that prevents any real TextInputs from being rendered
Browse files Browse the repository at this point in the history
Summary: There's an old hack in the C++ code that prevents TextInputs from being rendered by forcing them to render as Views instead. We don't need this anymore.

Reviewed By: shergin

Differential Revision: D16932795

fbshipit-source-id: 347df106f638c2bf936e2312f42bcb9310d72c6d
  • Loading branch information
JoshuaGross authored and facebook-github-bot committed Aug 21, 2019
1 parent 11dc847 commit 219e197
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions ReactCommon/fabric/uimanager/ComponentDescriptorRegistry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ static std::string componentNameByReactViewName(std::string viewName) {

// We need this temporarily for testing purposes until we have proper
// implementation of core components.
if (viewName == "SinglelineTextInputView" ||
viewName == "MultilineTextInputView" || viewName == "AndroidTextInput" ||
viewName == "SafeAreaView" || viewName == "ScrollContentView" ||
if (viewName == "SafeAreaView" || viewName == "ScrollContentView" ||
viewName == "AndroidHorizontalScrollContentView" // Android
) {
return "View";
Expand Down

0 comments on commit 219e197

Please sign in to comment.