Skip to content

Commit

Permalink
Add deprecation warning for NavigationExperimental
Browse files Browse the repository at this point in the history 
Summary: Starting in RN 0.43, lets start recommending people to move off of NavExperimental, now that a better navigation option is available, and hybrid options on the horizon.

Reviewed By: hramos

Differential Revision: D4634268

fbshipit-source-id: 2f37cc62f9729ae123d85f609a88f84516a5ae92
  • Loading branch information
@grabbou
Eric Vicenti authored and grabbou committed Mar 6, 2017
1 parent c72a448 commit 39eddc1
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions Libraries/NavigationExperimental/NavigationExperimental.js
View file
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@ const NavigationPropTypes = require('NavigationPropTypes');
const NavigationStateUtils = require('NavigationStateUtils'); const NavigationStateUtils = require('NavigationStateUtils');
const NavigationTransitioner = require('NavigationTransitioner'); const NavigationTransitioner = require('NavigationTransitioner');


const warning = require('fbjs/lib/warning');

// This warning will only be reached if the user has required the module
warning(
false,
'NavigationExperimental is deprecated and will be removed in a future ' +
'version of React Native. The NavigationExperimental views live on in ' +
'the React-Navigation project, which also makes it easy to declare ' +
'navigation logic for your app. Learn more at https://reactnavigation.org/'
);


const NavigationExperimental = { const NavigationExperimental = {
// Core // Core
StateUtils: NavigationStateUtils, StateUtils: NavigationStateUtils,
Expand Down

4 comments on commit 39eddc1

@JodiWarren
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvicenti Is there currently any schedule for removal, either firm or estimated? I'm just trying to plan out our transition to a different library.

@nihgwu
Copy link
Contributor

@nihgwu nihgwu commented on 39eddc1 Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JodiWarren It's already removed from the core in master branch

@JodiWarren
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihgwu Does that mean that it's likely to be removed in 0.44 then?

@kevinmcampos
Copy link

@kevinmcampos kevinmcampos commented on 39eddc1 Apr 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who doesn't use NavigationExperimental, it took me a long time to find React-Navigation project.
It will be reffered on the Navigation guide later?

Please sign in to comment.