Implement ReadableNative*::mapException without dynamic_cast

Summary:
Changing fbjni's mapException interface to use `std::exception_ptr`, this enables us to use `std::rethrow_exception` and `catch` statements to check for specific exception types, rather than using dynamic_casts and having an explicit dependency on RTTI.

While generally, we should always be enabling RTTI and exception support simultaneously, we have a number of targets where we don't, or where avoiding RTTI provides significant binary size gains.

Changelog: [Internal]

Reviewed By: mhorowitz

Differential Revision: D34379950

fbshipit-source-id: 446d105f9fb50ada3526f242f98e163215abd0ab

ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.cpp

@@ -20,13 +20,23 @@ __attribute__((visibility("default")))
 ReadableNativeArray::ReadableNativeArray(folly::dynamic array)
     : HybridBase(std::move(array)) {}
 
+// TODO T112842309: Remove after fbjni upgraded in OSS
 void ReadableNativeArray::mapException(const std::exception &ex) {
   if (dynamic_cast<const folly::TypeError *>(&ex) != nullptr) {
     throwNewJavaException(
         exceptions::gUnexpectedNativeTypeExceptionClass, ex.what());
   }
 }
 
+void ReadableNativeArray::mapException(std::exception_ptr ex) {
+  try {
+    std::rethrow_exception(ex);
+  } catch (const folly::TypeError &err) {
+    throwNewJavaException(
+        exceptions::gUnexpectedNativeTypeExceptionClass, err.what());
+  }
+}
+
 local_ref<JArrayClass<jobject>> ReadableNativeArray::importArray() {
   jint size = array_.size();
   auto jarray = JArrayClass<jobject>::newArray(size);

ReactAndroid/src/main/jni/react/jni/ReadableNativeArray.h

@@ -31,9 +31,11 @@ class ReadableNativeArray
       "Lcom/facebook/react/bridge/ReadableNativeArray;";
 
   static void mapException(const std::exception &ex);
+  static void mapException(std::exception_ptr ex);
+  static void registerNatives();
+
   jni::local_ref<jni::JArrayClass<jobject>> importArray();
   jni::local_ref<jni::JArrayClass<jobject>> importTypeArray();
-  static void registerNatives();
 };
 
 } // namespace react

ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.cpp

@@ -12,13 +12,23 @@ using namespace facebook::jni;
 namespace facebook {
 namespace react {
 
+// TODO T112842309: Remove after fbjni upgraded in OSS
 void ReadableNativeMap::mapException(const std::exception &ex) {
   if (dynamic_cast<const folly::TypeError *>(&ex) != nullptr) {
     throwNewJavaException(
         exceptions::gUnexpectedNativeTypeExceptionClass, ex.what());
   }
 }
 
+void ReadableNativeMap::mapException(std::exception_ptr ex) {
+  try {
+    std::rethrow_exception(ex);
+  } catch (const folly::TypeError &err) {
+    throwNewJavaException(
+        exceptions::gUnexpectedNativeTypeExceptionClass, err.what());
+  }
+}
+
 void addDynamicToJArray(
     local_ref<JArrayClass<jobject>> jarray,
     jint index,

ReactAndroid/src/main/jni/react/jni/ReadableNativeMap.h

@@ -42,7 +42,7 @@ struct ReadableNativeMap : jni::HybridClass<ReadableNativeMap, NativeMap> {
   static jni::local_ref<jhybridobject> createWithContents(folly::dynamic &&map);
 
   static void mapException(const std::exception &ex);
-
+  static void mapException(std::exception_ptr ex);
   static void registerNatives();
 
   using HybridBase::HybridBase;