Add broken fixture for objects with array props

Summary: Adds a broken fixture for arrays nested inside of objects (fixed in the next diffs) Reviewed By: TheSavior Differential Revision: D16896138 fbshipit-source-id: 355a71352a78ca076c1de56304908e664772c200
facebook · Aug 19, 2019 · 5f09a17 · 5f09a17
1 parent 3050ac2
commit 5f09a17
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 0 deletions.
diff --git a/packages/react-native-codegen/src/generators/components/__test_fixtures__/fixtures.js b/packages/react-native-codegen/src/generators/components/__test_fixtures__/fixtures.js
@@ -855,6 +855,35 @@ const OBJECT_PROPS: SchemaType = {
                       ],
                     },
                   },
+                  {
+                    name: 'nestedArrayAsProperty',
+                    optional: false,
+                    typeAnnotation: {
+                      type: 'ObjectTypeAnnotation',
+                      properties: [
+                        {
+                          name: 'arrayProp',
+                          optional: false,
+                          typeAnnotation: {
+                            type: 'ArrayTypeAnnotation',
+                            elementType: {
+                              type: 'ObjectTypeAnnotation',
+                              properties: [
+                                {
+                                  name: 'stringProp',
+                                  optional: false,
+                                  typeAnnotation: {
+                                    type: 'StringTypeAnnotation',
+                                    default: '',
+                                  },
+                                },
+                              ],
+                            },
+                          },
+                        },
+                      ],
+                    },
+                  },
                 ],
               },
             },

diff --git a/...ive-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsH-test.js.snap b/...ive-codegen/src/generators/components/__tests__/__snapshots__/GeneratePropsH-test.js.snap
@@ -884,6 +884,23 @@ static inline std::string toString(const ObjectPropsObjectPropNestedPropAStruct
   return \\"[Object ObjectPropsObjectPropNestedPropAStruct]\\";
 }
 
+struct ObjectPropsObjectPropNestedArrayAsPropertyStruct {
+  std::vector<ObjectPropsObjectPropNestedArrayAsPropertyArrayPropStruct> arrayProp;
+};
+
+static inline void fromRawValue(const RawValue &value, ObjectPropsObjectPropNestedArrayAsPropertyStruct &result) {
+  auto map = (better::map<std::string, RawValue>)value;
+
+  auto arrayProp = map.find(\\"arrayProp\\");
+  if (arrayProp != map.end()) {
+    fromRawValue(arrayProp->second, result.arrayProp);
+  }
+}
+
+static inline std::string toString(const ObjectPropsObjectPropNestedArrayAsPropertyStruct &value) {
+  return \\"[Object ObjectPropsObjectPropNestedArrayAsPropertyStruct]\\";
+}
+
 struct ObjectPropsObjectPropStruct {
   std::string stringProp;
   bool booleanProp;
@@ -893,6 +910,7 @@ struct ObjectPropsObjectPropStruct {
   ObjectPropsObjectPropObjectArrayPropStruct objectArrayProp;
   ObjectPropsObjectPropObjectPrimitiveRequiredPropStruct objectPrimitiveRequiredProp;
   ObjectPropsObjectPropNestedPropAStruct nestedPropA;
+  ObjectPropsObjectPropNestedArrayAsPropertyStruct nestedArrayAsProperty;
 };
 
 static inline void fromRawValue(const RawValue &value, ObjectPropsObjectPropStruct &result) {
@@ -930,6 +948,10 @@ static inline void fromRawValue(const RawValue &value, ObjectPropsObjectPropStru
   if (nestedPropA != map.end()) {
     fromRawValue(nestedPropA->second, result.nestedPropA);
   }
+  auto nestedArrayAsProperty = map.find(\\"nestedArrayAsProperty\\");
+  if (nestedArrayAsProperty != map.end()) {
+    fromRawValue(nestedArrayAsProperty->second, result.nestedArrayAsProperty);
+  }
 }
 
 static inline std::string toString(const ObjectPropsObjectPropStruct &value) {