Remove unneessary permissions, fixes #5886

facebook · Mar 15, 2017 · 65e5ee3 · 65e5ee3
1 parent 6336e4d
commit 65e5ee3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/local-cli/templates/HelloWorld/android/app/src/main/AndroidManifest.xml b/local-cli/templates/HelloWorld/android/app/src/main/AndroidManifest.xml
@@ -6,6 +6,12 @@
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
 
+    <!-- These permissions are added implicitly by android-jsc, see https://github.com/facebook/android-jsc/pull/12 -->
+    <!-- The following lines can be removed after android-jsc is updated in react-native -->
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove" />
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="remove" />
+    <uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove"/>
+
     <uses-sdk
         android:minSdkVersion="16"
         android:targetSdkVersion="22" />

diff --git a/local-cli/templates/HelloWorld/android/app/src/release/AndroidManifest.xml b/local-cli/templates/HelloWorld/android/app/src/release/AndroidManifest.xml
@@ -0,0 +1,8 @@
+<manifest
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    >
+
+    <!-- These are added by React Native for debug mode, but aren't needed in release mode -->
+    <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" tools:node="remove" />
+</manifest>