Skip to content

Commit

Permalink
add back hermes inspector support (#33778)
Browse files Browse the repository at this point in the history
Summary:
the `WITH_INSPECTOR` build flag is missing from cmake migration. original we had it in [Application.mk](https://github.com/facebook/react-native/blob/ed46ea2058b909a2dd401347d68956324961ec2c/ReactAndroid/src/main/jni/Application.mk#L29)

this pr adds back the build flag and make hermes inspector (or debugging hermes in flipper) work again.

## Changelog

[Android] [Fixed] - add back hermes inspector support

Pull Request resolved: #33778

Test Plan: test on rn-tester hermes variant

Reviewed By: cipolleschi

Differential Revision: D36204525

Pulled By: cortinico

fbshipit-source-id: 417874a7d0e05b5ee886f3160d526ff9c2df44ee
  • Loading branch information
Kudo authored and facebook-github-bot committed May 6, 2022
1 parent 73a4390 commit 6b6adcc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ReactAndroid/src/main/jni/react/jni/CMakeLists.txt
Expand Up @@ -14,7 +14,8 @@ add_compile_options(
-fexceptions
-frtti
-Wno-unused-lambda-capture
-std=c++17)
-std=c++17
-DWITH_INSPECTOR=1)

##########################
### React Native Utils ###
Expand Down

0 comments on commit 6b6adcc

Please sign in to comment.