Skip to content

Commit

Permalink
Rename addRootView to startSurface
Browse files Browse the repository at this point in the history
Summary: I'm only renaming the new `addRootView` that I added (which takes the moduleName, and uses startSurfaceWithConstraints), since the other one implements the UIManager interface method that's shared with paper.

Reviewed By: shergin

Differential Revision: D16432425

fbshipit-source-id: 392af42690052551504676df776bac6d1a968785
  • Loading branch information
Emily Janzer authored and facebook-github-bot committed Jul 25, 2019
1 parent 7266ebd commit 7244bae
Showing 1 changed file with 3 additions and 2 deletions.
Expand Up @@ -138,11 +138,12 @@ public FabricUIManager(
mReactApplicationContext.addLifecycleEventListener(this);
}

// TODO (T47819352): Rename this to startSurface for consistency with xplat/iOS
@Override
public <T extends View> int addRootView(
final T rootView, final WritableMap initialProps, final @Nullable String initialUITemplate) {
final int rootTag = ReactRootViewTagGenerator.getNextRootViewTag();
// TODO T31905686: Refactor both addRootView methods into one method
// TODO T31905686: Combine with startSurface below
ThemedReactContext reactContext =
new ThemedReactContext(mReactApplicationContext, rootView.getContext());
mMountingManager.addRootView(rootTag, rootView);
Expand All @@ -158,7 +159,7 @@ public <T extends View> int addRootView(
return rootTag;
}

public <T extends View> int addRootView(
public <T extends View> int startSurface(
final T rootView,
final String moduleName,
final WritableMap initialProps,
Expand Down

0 comments on commit 7244bae

Please sign in to comment.