Skip to content

Commit

Permalink
Migrate FbReactTTRCStepRenderFlagManager to JS codegen
Browse files Browse the repository at this point in the history
Summary: This diff migrates `FbReactTTRCStepRenderFlagManager` to use the generated `TTRCStepRenderFlagManagerDelegate` for setting its properties. A bit more work was required to migrate this view manager since it doesn't extend `BaseViewManager`, so I had to add an adapter which made it possible to pass an instance of `FbReactTTRCStepRenderFlagManager` to `TTRCStepRenderFlagManagerDelegate`.

Reviewed By: mdvacca

Differential Revision: D16984172

fbshipit-source-id: 7bf8c1342435c4e615eb9e7ca711f53c63ed3438
  • Loading branch information
makovkastar authored and facebook-github-bot committed Sep 4, 2019
1 parent d38afb4 commit 7715d18
Showing 1 changed file with 86 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
package com.facebook.react.uimanager;

import android.view.View;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;

public abstract class BaseViewManagerAdapter<T extends View>
implements BaseViewManagerInterface<T> {
@Override
public void setAccessibilityActions(@NonNull T view, ReadableArray accessibilityActions) {}

@Override
public void setAccessibilityHint(@NonNull T view, String accessibilityHint) {}

@Override
public void setAccessibilityLabel(@NonNull T view, String accessibilityLabel) {}

@Override
public void setAccessibilityLiveRegion(@NonNull T view, @Nullable String liveRegion) {}

@Override
public void setAccessibilityRole(@NonNull T view, @Nullable String accessibilityRole) {}

@Override
public void setViewState(@NonNull T view, @Nullable ReadableMap accessibilityState) {}

@Override
public void setBackgroundColor(@NonNull T view, int backgroundColor) {}

@Override
public void setBorderRadius(@NonNull T view, float borderRadius) {}

@Override
public void setBorderBottomLeftRadius(@NonNull T view, float borderRadius) {}

@Override
public void setBorderBottomRightRadius(@NonNull T view, float borderRadius) {}

@Override
public void setBorderTopLeftRadius(@NonNull T view, float borderRadius) {}

@Override
public void setBorderTopRightRadius(@NonNull T view, float borderRadius) {}

@Override
public void setElevation(@NonNull T view, float elevation) {}

@Override
public void setImportantForAccessibility(
@NonNull T view, @Nullable String importantForAccessibility) {}

@Override
public void setNativeId(@NonNull T view, String nativeId) {}

@Override
public void setOpacity(@NonNull T view, float opacity) {}

@Override
public void setRenderToHardwareTexture(@NonNull T view, boolean useHWTexture) {}

@Override
public void setRotation(@NonNull T view, float rotation) {}

@Override
public void setScaleX(@NonNull T view, float scaleX) {}

@Override
public void setScaleY(@NonNull T view, float scaleY) {}

@Override
public void setTestId(@NonNull T view, String testId) {}

@Override
public void setTransform(@NonNull T view, @Nullable ReadableArray matrix) {}

@Override
public void setTranslateX(@NonNull T view, float translateX) {}

@Override
public void setTranslateY(@NonNull T view, float translateY) {}

@Override
public void setZIndex(@NonNull T view, float zIndex) {}
}

0 comments on commit 7715d18

Please sign in to comment.