Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
Reviewed By: javache

Differential Revision: D5103275

fbshipit-source-id: 1df50ecef7b16289eecadde3c193db086eef1fc7
  • Loading branch information
aaronechiu authored and facebook-github-bot committed May 22, 2017
1 parent 130a821 commit 784f89d
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
Expand Up @@ -236,8 +236,8 @@ public void startReactApplication(
/**
* Unmount the react application at this root view, reclaiming any JS memory associated with that
* application. If {@link #startReactApplication} is called, this method must be called before the
* ReactRootView is garbage collected (typically in your Activity's onDestroy, or in your Fragment's
* onDestroyView).
* ReactRootView is garbage collected (typically in your Activity's onDestroy, or in your
* Fragment's onDestroyView).
*/
public void unmountReactApplication() {
if (mReactInstanceManager != null && mIsAttachedToInstance) {
Expand Down Expand Up @@ -339,10 +339,11 @@ protected void finalize() throws Throwable {
super.finalize();
Assertions.assertCondition(
!mIsAttachedToInstance,
"The application this ReactRootView was rendering was not unmounted before the ReactRootView " +
"was garbage collected. This usually means that your application is leaking large amounts of " +
"memory. To solve this, make sure to call ReactRootView#unmountReactApplication in the onDestroy() " +
"of your hosting Activity or in the onDestroyView() of your hosting Fragment.");
"The application this ReactRootView was rendering was not unmounted before the " +
"ReactRootView was garbage collected. This usually means that your application is " +
"leaking large amounts of memory. To solve this, make sure to call " +
"ReactRootView#unmountReactApplication in the onDestroy() of your hosting Activity or in " +
"the onDestroyView() of your hosting Fragment.");
}

public int getRootViewTag() {
Expand Down

0 comments on commit 784f89d

Please sign in to comment.