Skip to content

Commit

Permalink
chore: fail prepare package for release if tag exists (#35305)
Browse files Browse the repository at this point in the history
Summary:
This PR makes sure that the `preapre_package_for_release` script fail fast if there is already a tag for the desired version
on github.

## Changelog

[General] [Added] - Make the `prepare_package_for_release` fail if there is already a git tag with that version

Pull Request resolved: #35305

Test Plan:
Tested manually. The script is currently only invoked during the release process.
<img width="1238" alt="Screenshot 2022-11-10 at 12 24 03" src="https://user-images.githubusercontent.com/11162307/201090947-274c1b1c-0b6a-4619-bc85-fa60e5eaeee1.png">

Reviewed By: cortinico

Differential Revision: D41403159

Pulled By: cipolleschi

fbshipit-source-id: fb87df345b14568c750482e5c68be53551a9acbb
  • Loading branch information
Riccardo Cipolleschi authored and facebook-github-bot committed Nov 21, 2022
1 parent 5dd0f73 commit 850f855
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
2 changes: 2 additions & 0 deletions scripts/bump-oss-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const request = require('request');
const {getBranchName, exitIfNotOnGit} = require('./scm-utils');

const {parseVersion, isReleaseBranch} = require('./version-utils');
const {failIfTagExists} = require('./release-utils');

let argv = yargs
.option('r', {
Expand Down Expand Up @@ -75,6 +76,7 @@ async function main() {
);
const token = argv.token;
const releaseVersion = argv.toVersion;
failIfTagExists(releaseVersion);

const {pushed} = await inquirer.prompt({
type: 'confirm',
Expand Down
3 changes: 3 additions & 0 deletions scripts/prepare-package-for-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
const {echo, exec, exit} = require('shelljs');
const yargs = require('yargs');
const {isReleaseBranch, parseVersion} = require('./version-utils');
const {failIfTagExists} = require('./release-utils');

const argv = yargs
.option('r', {
Expand Down Expand Up @@ -49,6 +50,8 @@ const releaseVersion = argv.toVersion;
const isLatest = argv.latest;
const isDryRun = argv.dryRun;

failIfTagExists(releaseVersion);

if (branch && !isReleaseBranch(branch) && !isDryRun) {
console.error(`This needs to be on a release branch. On branch: ${branch}`);
exit(1);
Expand Down
19 changes: 19 additions & 0 deletions scripts/release-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,27 @@ function generateiOSArtifacts(
return tarballOutputPath;
}

function failIfTagExists(version) {
if (checkIfTagExists(version)) {
echo(`Tag v${version} already exists.`);
echo('You may want to rollback the last commit');
echo('git reset --hard HEAD~1');
exit(1);
}
}

function checkIfTagExists(version) {
const {code, stdout} = exec('git tag -l', {silent: true});
if (code !== 0) {
throw new Error('Failed to retrieve the list of tags');
}
const tags = new Set(stdout.split('\n'));
return tags.has(`v${version}`);
}

module.exports = {
generateAndroidArtifacts,
generateiOSArtifacts,
publishAndroidArtifactsToMaven,
failIfTagExists,
};

0 comments on commit 850f855

Please sign in to comment.