-
Notifications
You must be signed in to change notification settings - Fork 24.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Wrap textInput with KeyboardAvoidingView
Differential Revision: D6693570 fbshipit-source-id: f6946074d82cef2c68454bfc829c30013d19a151
- Loading branch information
1 parent
2c74f93
commit 85bd98e
Showing
1 changed file
with
10 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85bd98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit message does not describe code changes 👎
85bd98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the commit where the actual wrapping takes place (as per the commit message). But I see that this commit will enable it by default. I suppose that many apps already has KAV in place. Setting enabled=true by default would be a breaking change for all those apps, wouldn't it?
85bd98e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msageryd No,
enabled
added properly. Before this change KAV behave (I actually looks only at this diff) as it always enabled. What this code change adds, is actually "allow to disable KAV".But with such commit message, no one could see the error if even it was here.