Skip to content

Commit

Permalink
Prevent OSS build breakage due to unused-local-typedef (#43449)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #43449

Error:

```
react-native/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp:162:5: error: unused typedef 'INVALID_REQUESTED_LOG_SEVERITY' [-Werror,-Wunused-local-typedef]
      LOG_EVERY_N(INFO, 10) << "instanceHandle is null, event of type " << type
      ^
  react-native/packages/react-native/ReactAndroid/build/third-party-ndk/glog/exported/glog/logging.h:943:30: note: expanded from macro 'LOG_EVERY_N'
                               INVALID_REQUESTED_LOG_SEVERITY);           \
                               ^
  1 error generated.
  ninja: build stopped: subcommand failed.
```

This has been fixed upstream (google/glog@8b3023f) but we're on an older glog version, so ignore the error.

Changelog: [Internal]

Reviewed By: fabriziocucci

Differential Revision: D54811655

fbshipit-source-id: a00c23528d457ae365b0a27e680bb46afabb152f
  • Loading branch information
javache authored and facebook-github-bot committed Mar 12, 2024
1 parent 3341ab7 commit 9af98cc
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ add_compile_options(
-std=c++20
-Wall
-Wpedantic
-Wno-unused-local-typedef
-DLOG_TAG=\"Fabric\")

file(GLOB react_render_uimanager_SRC CONFIGURE_DEPENDS *.cpp)
Expand Down

0 comments on commit 9af98cc

Please sign in to comment.