Permalink
Browse files

Fix webview crash when trying to display local html files

Summary:
When using webview on android and trying to link to an html file located on device (using `file://`), the application would crash with an error specifying that nothing handles the fired intent. This is due to [`33a1f28`](33a1f28) which attempts to intercept all non `http(s)` links.

This is a simple fix so hopefully it can make it into the next stable release.
Closes #9668

Differential Revision: D3956485

fbshipit-source-id: 5a752abc21802a44e3a26e88669ccb6852076992
  • Loading branch information...
1 parent 1a9853d commit a2aab625f3da4f24c42ed205150886ce867b4835 @andy9775 andy9775 committed with Facebook Github Bot Oct 1, 2016
@@ -118,7 +118,8 @@ public void onPageStarted(WebView webView, String url, Bitmap favicon) {
@Override
public boolean shouldOverrideUrlLoading(WebView view, String url) {
- if (url.startsWith("http://") || url.startsWith("https://")) {
+ if (url.startsWith("http://") || url.startsWith("https://") ||
+ url.startsWith("file://")) {
return false;
} else {
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));

0 comments on commit a2aab62

Please sign in to comment.