Skip to content

Commit

Permalink
Upgrade OSS target sdk version to 34 (#39103)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39103

Changelog:
[Android][Changed] - Upgrade target sdk version to 34

Reviewed By: cortinico

Differential Revision: D48555585

fbshipit-source-id: 05a89fecdea52d73d35ba3fed8df76fc6bf51fe6
  • Loading branch information
Lulu Wu authored and facebook-github-bot committed Aug 22, 2023
1 parent c22cc8f commit a6b0984
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
as the min SDK to lint the file.-->
<uses-sdk
android:minSdkVersion="21"
android:targetSdkVersion="33"
android:targetSdkVersion="34"
/>

</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,8 @@ public void setPackagerLocationCustomizer(
*/
private void compatRegisterReceiver(
Context context, BroadcastReceiver receiver, IntentFilter filter, boolean exported) {
if (Build.VERSION.SDK_INT >= 34 && context.getApplicationInfo().targetSdkVersion >= 34) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE
&& context.getApplicationInfo().targetSdkVersion >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
context.registerReceiver(
receiver, filter, exported ? Context.RECEIVER_EXPORTED : Context.RECEIVER_NOT_EXPORTED);
} else {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[versions]
# Android versions
minSdk = "21"
targetSdk = "33"
targetSdk = "34"
compileSdk = "34"
buildTools = "34.0.0"
# Dependencies versions
Expand Down
6 changes: 3 additions & 3 deletions packages/react-native/template/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

buildscript {
ext {
buildToolsVersion = "33.0.1"
buildToolsVersion = "34.0.0"
minSdkVersion = 21
compileSdkVersion = 33
targetSdkVersion = 33
compileSdkVersion = 34
targetSdkVersion = 34
ndkVersion = "25.1.8937393"
kotlinVersion = "1.8.0"
}
Expand Down

0 comments on commit a6b0984

Please sign in to comment.