Skip to content

Commit

Permalink
Make RCTNativeAnimatedModule a regular NativeModule
Browse files Browse the repository at this point in the history
Summary: We suspect that RCTNativeAnimatedModule's conversion to TurboModule could be the cause. There could be a memory leak in the TurboModule system that RCTNativeAnimatedModule exposes, or RCTNativeAnimatedModule itself could have a memory leak. Therefore, I'm making RCTNativeAnimatedModule a regular NativeModule for now.

Reviewed By: fkgozali

Differential Revision: D18410852

fbshipit-source-id: dd714fe0fb0267fe5e1a94a26d47a82199b6f2c7
  • Loading branch information
RSNara authored and facebook-github-bot committed Nov 12, 2019
1 parent bca8fa5 commit a95184c
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions Libraries/NativeAnimation/RCTNativeAnimatedModule.mm
Expand Up @@ -15,9 +15,6 @@

typedef void (^AnimatedOperation)(RCTNativeAnimatedNodesManager *nodesManager);

@interface RCTNativeAnimatedModule() <NativeAnimatedModuleSpec>
@end

@implementation RCTNativeAnimatedModule
{
RCTNativeAnimatedNodesManager *_nodesManager;
Expand Down Expand Up @@ -335,11 +332,6 @@ - (void)eventDispatcherWillDispatchEvent:(id<RCTEvent>)event
});
}

- (std::shared_ptr<facebook::react::TurboModule>)getTurboModuleWithJsInvoker:(std::shared_ptr<facebook::react::CallInvoker>)jsInvoker
{
return std::make_shared<facebook::react::NativeAnimatedModuleSpecJSI>(self, jsInvoker);
}

@end

Class RCTNativeAnimatedModuleCls(void) {
Expand Down

0 comments on commit a95184c

Please sign in to comment.