Skip to content

Commit

Permalink
Remove stale task/comment in FabricUIManager (#40768)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #40768

The task referenced is 4 years old and it doesn't seem to be relevant anymore given that:
* `addRootView` has been marked as deprecated
* there is an explicit check in `addRootView` mentioning:

> Do not call addRootView in Fabric; it is unsupported. Call startSurface instead

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D50122192

fbshipit-source-id: fe02d481b47663f5bdf4fb7527e480117f00be47
  • Loading branch information
fabriziocucci authored and facebook-github-bot committed Oct 10, 2023
1 parent 9e068ac commit b1356fe
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ public FabricUIManager(
mReactApplicationContext.registerComponentCallbacks(viewManagerRegistry);
}

// TODO (T47819352): Rename this to startSurface for consistency with xplat/iOS
@Override
@UiThread
@ThreadConfined(UI)
Expand Down

0 comments on commit b1356fe

Please sign in to comment.